[ 
https://issues.apache.org/jira/browse/CB-9214?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14610020#comment-14610020
 ] 

ASF GitHub Bot commented on CB-9214:
------------------------------------

GitHub user cwannerstedt opened a pull request:

    https://github.com/apache/cordova-plugin-statusbar/pull/27

    CB-9214 - [iOS] Landscape webview height is calculated wrong

    Fix for the incorrectly calculated statusbar height, when hiding the 
statusbar in landscape orientation in iOS 8.
    
    At first I thought I use the IsAtLeastiOSVersion macro, but then I noticed 
it had already been tested in https://issues.apache.org/jira/browse/CB-7549, so 
I replaced it with a more fool proof solution..

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/cwannerstedt/cordova-plugin-statusbar master

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/cordova-plugin-statusbar/pull/27.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #27
    
----
commit 07b55b752960e66ca4d0ba33b9c49d41b7241b43
Author: Christian Wannerstedt <[email protected]>
Date:   2015-07-01T11:25:26Z

    Use correct statusbar height for landscape orientation in iOS >= 8

commit 3e821abfc2888b77a3e86657698a2d6774152793
Author: Christian Wannerstedt <[email protected]>
Date:   2015-07-01T11:49:50Z

    Don't use IsAtLeastiOSVersion macro to determine height

----


> [StatusBar][iOS] Landscape webview height is calculated wrong
> -------------------------------------------------------------
>
>                 Key: CB-9214
>                 URL: https://issues.apache.org/jira/browse/CB-9214
>             Project: Apache Cordova
>          Issue Type: Bug
>          Components: Plugin Statusbar
>    Affects Versions: 5.0.0
>         Environment: [email protected]
> [email protected]
> [email protected]
> [email protected]
>            Reporter: Mark van Beek
>
> Using an iPad (screen size: 1024x768 in landscape) I noticed that the button 
> bar I put at the bottom of the screen was not there. Looking for the cause 
> (since it works in the browser), I started looking at the height reported by 
> the html tag (css: width: 100%; height: 100%). Here it showed that the size 
> was 1024x1772, meaning the size of the viewport was actually 1024x1772 
> (instead of 1024x768). After a lot of trail and error, googling and such, I 
> came across an old issue (https://issues.apache.org/jira/browse/CB-7549) 
> which gave me the idea to change the FullScreen & StatusBarOverlaysWebView 
> from false to true and finally the issue disappeared.
> Since 1772 == 768 + 1024 - 20, it seems like the computation for the 
> remaining height for the webview when the statusbar is not overlayed goes 
> wrong (at least in landscape mode)...



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to