[ 
https://issues.apache.org/jira/browse/CB-9275?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14614664#comment-14614664
 ] 

ASF GitHub Bot commented on CB-9275:
------------------------------------

Github user vladimir-kotikov commented on a diff in the pull request:

    
https://github.com/apache/cordova-plugin-file-transfer/pull/91#discussion_r33911944
  
    --- Diff: src/wp/FileTransfer.cs ---
    @@ -437,10 +438,10 @@ public void upload(string options)
             {
                 try
                 {
    -                if (FileTransfer.HasJsonDotNet)
    +                if (FileTransfer.JsonDeserializeUsingJsonNet != null)
                     {
    -                    return 
JsonHelper.Deserialize<Header[]>(jsonHeaders,true)
    -                        .ToDictionary(header => header.Name, header => 
header.Value);
    +                    return 
((Header[])FileTransfer.JsonDeserializeUsingJsonNet.Invoke(null, new object[] { 
jsonHeaders, true }))
    +                         .ToDictionary(header => header.Name, header => 
header.Value);
    --- End diff --
    
    nit: extra space


> cordova-plugin-file-transfer fails to build on WP8
> --------------------------------------------------
>
>                 Key: CB-9275
>                 URL: https://issues.apache.org/jira/browse/CB-9275
>             Project: Apache Cordova
>          Issue Type: Bug
>          Components: Plugin File Transfer, WP8
>    Affects Versions: 1.2.1
>            Reporter: Nikhil Khandelwal
>            Assignee: Nikhil Khandelwal
>
> REPRO STEPS:
> 1. cordova create test
> 2. cordova plugin add cordova-plugin-file-transfer
> 3. cordova platform add wp8
> 4. cordova build
> EXPECTED RESULTS:
> No compile error
> ACTUAL RESULTS:
> Compile error because of referencing a type in unreleased master version of 
> cordova-wp8.
> Plugins\cordova-plugin-file-transfer\FileTransfer.cs(442,28): error CS1501: 
> No overload for method 'Deserialize' takes 2 ar guments 
> [d:\apps\test\platforms\wp8\HelloCordova.csproj]



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to