[
https://issues.apache.org/jira/browse/CB-9335?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14624230#comment-14624230
]
ASF GitHub Bot commented on CB-9335:
------------------------------------
Github user TimBarham commented on the pull request:
https://github.com/apache/cordova-windows/pull/98#issuecomment-120820494
Looks good to me.
Have you verified no changes need to be made to
`cordova-lib/src/util/windows/jsprojManager.js` (adding/removing plugins that
use `<lib-file>` or `<framework>` elements for the windows platform)? Also, you
might want to update `cordova-lib/spec-plugman/projects/windows/CordovaApp.sln`
to reflect this change.
Assuming that's all good, is this ready to be merged?
> Windows quality-of-life improvements
> ------------------------------------
>
> Key: CB-9335
> URL: https://issues.apache.org/jira/browse/CB-9335
> Project: Apache Cordova
> Issue Type: Bug
> Components: Windows
> Reporter: Rob Paveza
> Assignee: Rob Paveza
> Priority: Trivial
>
> --archs argument doesn't document its separator but it supports multiple
> parameters
> -- the Windows 8 project is the startup project if opening the solution file,
> but it should be 8.1. (Consider removing the Windows 8 project from the main
> solution file anyway).
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
