[
https://issues.apache.org/jira/browse/CB-9361?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14625676#comment-14625676
]
ASF GitHub Bot commented on CB-9361:
------------------------------------
GitHub user TimBarham opened a pull request:
https://github.com/apache/cordova-coho/pull/91
CB-9361 Make verify-tags working nicely with Windows command prompt.
The `verify-tags` command currently relies on users hitting `Ctrl+D` to
trigger the end of input. However, this doesn't work in the Windows command
prompt.
I've modified this to use Node's `readline` module - read the input line by
line, then process when an empty line is encountered. This way, the tags can be
pasted then simply press `Enter`. On Unix-like systems, `Ctrl+D` will continue
to work (and if you pipe in a file that will still work), since the `EOF` will
trigger the `close` event.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/MSOpenTech/cordova-coho CB-9361
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/cordova-coho/pull/91.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #91
----
commit 4dee85aa0efd79572bfeaae1e6b8499ae8e17001
Author: Tim Barham <[email protected]>
Date: 2015-07-14T01:39:32Z
CB-9361 Make verify-tags working nice with Windows command prompt.
The verify-tags command currently relies on users entering a Ctrl+D to
trigger the end of input. However, this doesn't work in the Windows command
prompt.
I've modified this to use Node's readline module - read the input line by
line, then process when an empty line is encountered. This way, the tags can be
pasted then simply press Enter. Note that on Unix-like systems, Ctrl+D will
still work (and if you pipe in a file that doesn't have a blank line at the
end, that will still work), since the EOF will trigger the 'close' event.
----
> The coho verify-tags command does not work well in Windows
> ----------------------------------------------------------
>
> Key: CB-9361
> URL: https://issues.apache.org/jira/browse/CB-9361
> Project: Apache Cordova
> Issue Type: Bug
> Components: Coho
> Reporter: Tim Barham
> Assignee: Tim Barham
> Original Estimate: 4h
> Remaining Estimate: 4h
>
> The coho {{verify-tags}} command requires users to type {{Ctrl+D}} to trigger
> an {{EOF}}. However, this does not work from the Windows command prompt.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
