[
https://issues.apache.org/jira/browse/CB-6190?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14626856#comment-14626856
]
ASF GitHub Bot commented on CB-6190:
------------------------------------
GitHub user jcesarmobile opened a pull request:
https://github.com/apache/cordova-plugin-camera/pull/108
CB-6190 - iOS camera plugin ignores quality parameter
CB-6190 - iOS camera plugin ignores quality parameter in some
circunstances
Added a check to not downscale if quality is 100 or sourceType !=
UIImagePickerControllerSourceTypeCamera (according to the docs, images
from gallery aren’t downscaled)
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/jcesarmobile/cordova-plugin-camera CB-6190
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/cordova-plugin-camera/pull/108.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #108
----
commit 6746b8c1445d7a70e039a9bd5ce36ea010747989
Author: Julio César <[email protected]>
Date: 2015-07-14T18:53:40Z
CB-6190 - iOS camera plugin ignores quality parameter
CB-6190 - iOS camera plugin ignores quality parameter in some
circunstances
Added a check to not downscale if quality is 100 or sourceType !=
UIImagePickerControllerSourceTypeCamera (according to the docs, images
from gallery aren’t downscaled)
----
> navigator.camera.getPicture ignores quality parameter when width/height are
> not specified
> -----------------------------------------------------------------------------------------
>
> Key: CB-6190
> URL: https://issues.apache.org/jira/browse/CB-6190
> Project: Apache Cordova
> Issue Type: Bug
> Components: Plugin Camera
> Environment: iOS
> Reporter: Youval Bronicki
> Assignee: jcesarmobile
>
> When calling navigator.camera.getPicture with default options except for
> quality, the requested quality is ignored.
> There is a simple work-around, replacing lines 314-315 in CDVCamera.m, :
> {quote}
> // use image unedited as requested , don't resize
> data = UIImageJPEGRepresentation(returnedImage, 1.0);
> {quote}
> with:
> {quote}
> // use image unedited as requested , don't resize (with compression)
> data = UIImageJPEGRepresentation(returnedImage, cameraPicker.quality /
> 100.0f);
> {quote}
> However, the code hints there may be some (undocumented?) intention to
> minimize processing in some situations, so this may not be a full fix.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
