[ 
https://issues.apache.org/jira/browse/CB-9371?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14628229#comment-14628229
 ] 

ASF GitHub Bot commented on CB-9371:
------------------------------------

GitHub user cjpearson opened a pull request:

    https://github.com/apache/cordova-lib/pull/260

    CB-9371: Don't delete orientation preferences by default

    

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/cjpearson/cordova-lib orientation-bug

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/cordova-lib/pull/260.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #260
    
----
commit a3c86157dd5354db26ba18eabc40cb8eaa8e0351
Author: Connor Pearson <[email protected]>
Date:   2015-07-15T15:06:09Z

    Don't delete orientation preferences by default

----


> Prepare deletes orientation preferences
> ---------------------------------------
>
>                 Key: CB-9371
>                 URL: https://issues.apache.org/jira/browse/CB-9371
>             Project: Apache Cordova
>          Issue Type: Bug
>          Components: CordovaLib
>    Affects Versions: 5.1.1
>            Reporter: Connor Pearson
>
> If a user does not have a orientation preference defined in config.xml then 
> running prepare will delete all orientation preferences in their info.plist.
> I'd expect prepare to overwrite the values if the user chose an orientation 
> preferences, otherwise it should respect the values that are already there.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to