[
https://issues.apache.org/jira/browse/CB-9359?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14628864#comment-14628864
]
ASF GitHub Bot commented on CB-9359:
------------------------------------
Github user nikhilkh commented on a diff in the pull request:
https://github.com/apache/cordova-windows/pull/102#discussion_r34736868
--- Diff: template/cordova/lib/MSBuildTools.js ---
@@ -38,6 +38,13 @@ MSBuildTools.prototype.buildProject = function(projFile,
buildType, buildarch) {
'/p:Configuration=' + buildType,
'/p:Platform=' + buildarch];
+ if (otherConfigProperties) {
--- End diff --
This approach is not consistent with other ways we've done this in the code
here. For packaging, we've leaned on generating a targets file every time we
build. We should use that same mechanism here:
https://github.com/apache/cordova-windows/blob/master/template/cordova/lib/prepare.js#L74
Also, one of the downsides of this approach is that IDE <-> command line
interop is broken. It's desirable for the IDE build to have the same results as
the command line build. By adding an additional property at command line this
can't be guaranteed.
> Add support for app package bundling to Windows 8.1 / Windows 10
> ----------------------------------------------------------------
>
> Key: CB-9359
> URL: https://issues.apache.org/jira/browse/CB-9359
> Project: Apache Cordova
> Issue Type: Task
> Components: Windows
> Reporter: Rob Paveza
> Assignee: Rob Paveza
>
> When generating a release build, developers are able to submit a single
> binary (an .appx bundle) to the Windows Store to avoid having to upload
> multiple app packages (particularly when building an architecture-specific
> app). This task should add a --bundle flag to enable automatic creation of
> an .appxbundle for upload of the app to the Store.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
