[
https://issues.apache.org/jira/browse/CB-9347?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14630021#comment-14630021
]
ASF GitHub Bot commented on CB-9347:
------------------------------------
GitHub user jcesarmobile opened a pull request:
https://github.com/apache/cordova-plugin-dialogs/pull/54
CB-9347 - fix to allow to stack multiple UIAlertControllers
Now you can stack multiple UIAlertControllers
I had to add a 0.5s delay in case the user tries to present a new
UIAlertController while one is currently being presented (on presenting
animation)
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/jcesarmobile/cordova-plugin-dialogs master
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/cordova-plugin-dialogs/pull/54.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #54
----
commit 98d3e90cd3b4879bed06c655dc9641107037c678
Author: Julio César <[email protected]>
Date: 2015-07-16T17:10:06Z
CB-9347 - fix to allow to stack multiple UIAlertControllers
Now you can stack multiple UIAlertControllers
I had to add a 0.5s delay in case the user tries to present a new
UIAlertController while one is currently being presented (on presenting
animation)
----
> You can no longer stack alerts in cordova-plugin-dialogs - commit #ee3b02b3
> has caused this
> -------------------------------------------------------------------------------------------
>
> Key: CB-9347
> URL: https://issues.apache.org/jira/browse/CB-9347
> Project: Apache Cordova
> Issue Type: Bug
> Components: iOS, Plugin Dialogs
> Affects Versions: 1.1.0
> Environment: Mac OS X Yosemite 10.10.4; XCode 6.4
> Reporter: Kelvin Dart
> Assignee: jcesarmobile
> Priority: Critical
>
> Previously in cordova-plugin-dialogs, you could stack alerts in Cordova like
> follows:
> {code}
> navigator.notification.alert('Notification 1', function () {}, 'Title 1');
> navigator.notification.alert('Notification 2', function () {}, 'Title 2');
> {code}
> And it would show 'Notification 2' then 'Notification 1'.
> Now you cannot, in commit: #ee3b02b3c78debe608263d847f7ac69bda1bfca0, there
> was quite a large overhaul in {{showDialogWithMessage}} in
> {{CDVNotification.m}}; this commit seems to add some code for iOS 8.3+ which
> uses {{UIAlertController}} instead of the old {{UIAlertView}}. The problem is
> here - unfortunately I do not know Obj-C too well in order to debug it.
> If you revert to a cordova-plugin-dialogs version prior to this, the stacked
> notifications work fine.
> I have created a small test harness which you can download
> [here|https://www.dropbox.com/s/62hdp3gjp2924er/CDVDialogsNotificationBug.zip?dl=0].
> Please could you implement the old behaviour as this has cause some aspects
> of my app to break - thanks!
> N.b. I have tagged the version as 1.1.0 as it would not allow me to tag 1.1.1.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
