[
https://issues.apache.org/jira/browse/CB-9235?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14636876#comment-14636876
]
ASF GitHub Bot commented on CB-9235:
------------------------------------
Github user vladimir-kotikov commented on the pull request:
https://github.com/apache/cordova-windows/pull/92#issuecomment-123712167
> When I run this branch on my local, I get an npm test failure for
check_reqs.spec.js, failing to find config.xml in cordova-windows root.
Sorry, that was my bad. [Fixed this
here](https://github.com/MSOpenTech/cordova-windows/commit/e3f4a7880bbc9a5c3af0f09637235d66fe6762ba#diff-f477d7d5a4a7b8cc0bfe70b71a81920fR71)
> build.spec.js spec.13 fails because it doesn't mock
findAllAvailableVersions
I can't repro this. build specs are all passing on my local machine.
Probably merge issues?
> make sure your AppVeyor passes - I think it's a problem with check_reqs
AppVeyor tests was failing because AppVeyor machines has UAC disabled (I
already mentioned that in one of my PRs, can't find it now), so the `run`
command was failing. See
https://github.com/apache/cordova-windows/blob/master/template/cordova/lib/run.js#L38.
I've updated `run` command and its tests, so this condition is now mocked, and
tests are passing even under the elevated prompt.
> Enhance check_reqs for Windows to include more checks
> -----------------------------------------------------
>
> Key: CB-9235
> URL: https://issues.apache.org/jira/browse/CB-9235
> Project: Apache Cordova
> Issue Type: Bug
> Components: Windows
> Affects Versions: 4.0.0
> Reporter: Vladimir Kotikov
> Assignee: Vladimir Kotikov
>
> For Windows the requirements will vary depending on the version of Windows
> you are targeting:
> _8.1:_
> * MSBuild
> * VS 2013
> _Phone:_
> * 8.1 Phone support – at least VS 2013 Update 2.
> * Phone SDK
> _Win 10:_
> * UAP Windows SDK
> * VS 2015 RC+
> We'll need to enhance check_reqs for Windows with more checks based on the
> windows-target-version and windows-phone-target-version.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
