[ 
https://issues.apache.org/jira/browse/CB-8941?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14637490#comment-14637490
 ] 

ASF GitHub Bot commented on CB-8941:
------------------------------------

GitHub user timwindsor opened a pull request:

    https://github.com/apache/cordova-blackberry/pull/187

    CB-8941 - Adds support for subdomain whitelisting like other platforms

    Finds //*. in access origins and creates access objects with the base 
domain and subdomains set true

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/timwindsor/cordova-blackberry CB-8941

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/cordova-blackberry/pull/187.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #187
    
----
commit 648aad5875585892eb8fd4c5bdc9274512324149
Author: Tim Windsor <[email protected]>
Date:   2015-06-25T21:46:04Z

    Finds //*. in access origins and creates access objects with the base 
domain and subdomains set true

----


> Subdomain whitelisting on bb10 does not match up with android
> -------------------------------------------------------------
>
>                 Key: CB-8941
>                 URL: https://issues.apache.org/jira/browse/CB-8941
>             Project: Apache Cordova
>          Issue Type: Bug
>          Components: BlackBerry
>    Affects Versions: 5.0.0
>            Reporter: Jenny Gee
>            Assignee: Josh Soref
>            Priority: Minor
>
> We need to support this format like the other platforms:
> {code:xml}
>   <access origin="http://*.google.com"; />
> {code}
> See this file:
> bin/templates/project/cordova/lib/config-parser.js
> lines that are of interest:
> {code}
> data.access.forEach(function (accessElement) {
> ...
> if (attribs.uri === "*" || attribs.origin === "*") {                          
>    
> ...
> widgetConfig.accessList.push(createAccessListObj(attribs.uri || 
> attribs.origin, attribs.subdomains));
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to