[ 
https://issues.apache.org/jira/browse/CB-9429?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14646020#comment-14646020
 ] 

ASF GitHub Bot commented on CB-9429:
------------------------------------

GitHub user vladimir-kotikov opened a pull request:

    https://github.com/apache/cordova-js/pull/123

    CB-9429 Enables jsdom/browser tests for browserify

    This PR implements 
[CB-9429](https://issues.apache.org/jira/browse/CB-9429). It also:
      - Fixes browser-based tests problems (browser not launched, tests files 
served improperly), so `grunt btest` command now works.
      - Adds `test` platform to `compile-browserify` target
      - Add `test-browserify` and `btest-browserify` Grunt targets to run 
cordova-js tests against browserified bundle

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/MSOpenTech/cordova-js CB-9429

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/cordova-js/pull/123.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #123
    
----
commit ba4dcd8e0a0458c1969d4ec7e3965d37d74f1958
Author: Vladimir Kotikov <[email protected]>
Date:   2015-07-29T07:49:56Z

    Enables/fixes browser-based tests
    
    Also enables both browser and JSDom tests for browserify flow.

commit adbe1885b118161f0bd19d82a748653ae0f8ba25
Author: Vladimir Kotikov <[email protected]>
Date:   2015-07-29T10:42:11Z

    CB-9429 Enables jsdom/browser tests for browserify

commit 42e6a6d26f7eb224e7317d6831f4028f9f7abc69
Author: Vladimir Kotikov <[email protected]>
Date:   2015-07-29T10:42:11Z

    Moves test platform sources to platforms directory
    
    Updates tests with new test platform paths
    Updates bundlers to use new test platform path

commit 4107d66a0f59000096f868a46aebb40d8f6688f2
Author: Vladimir Kotikov <[email protected]>
Date:   2015-07-29T10:42:11Z

    Fixes malformed bundle by adding symbol list

----


> Add option to run cordova-js tests against browserified bundle.
> ---------------------------------------------------------------
>
>                 Key: CB-9429
>                 URL: https://issues.apache.org/jira/browse/CB-9429
>             Project: Apache Cordova
>          Issue Type: Task
>          Components: CordovaJS
>    Affects Versions: 4.1.0
>            Reporter: Vladimir Kotikov
>            Assignee: Vladimir Kotikov
>
> There is no way currently to run cordova-js tests with browserified 
> cordova-js bundle, so the only way to test browserify flow is to 
> create/build/run mobilespec with {{--browserify}} option.
> However there is still problems with browserify and test-framework, so even 
> this way is not available now.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to