[ 
https://issues.apache.org/jira/browse/CB-9430?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Vadim Shlyakhov updated CB-9430:
--------------------------------
    Description: 
lib/check_reqs.js fails if javac returns an extra line(s) instead of a single 
line, for example: 
{quote}
Picked up _JAVA_OPTIONS: -Dawt.useSystemAAFontSettings=gasp
javac 1.7.0_79
{quote}
instead of simply
bq. javac 1.7.0_79

The fix is quite simple:
{quote}
{noformat}
--- check_reqs.js-      2015-07-29 14:21:54.000000000 +0300
+++ check_reqs.js       2015-07-29 16:11:29.000000000 +0300
@@ -155,7 +155,7 @@
             // javac writes version info to stderr instead of stdout
             return tryCommand('javac -version', msg, true);
         }).then(function (output) {
-            return /^javac ((?:\d+\.)+(?:\d+))/i.exec(output)[1];
+            return /javac ((?:\d+\.)+(?:\d+))/i.exec(output)[1];
         });
     });
 };
{noformat}
{quote}

i. e. remove leading caret at the parsing regular expression, so it is not 
anchored to a beginning of a string.

  was:
lib/check_reqs.js fails if javac returns an extra line(s) instead of a single 
line, for example: 
{quote}
Picked up _JAVA_OPTIONS: -Dawt.useSystemAAFontSettings=gasp
javac 1.7.0_79
{quote}
instead of simply
bq. javac 1.7.0_79

The fix is quite simple:
{quote}
--- check_reqs.js-      2015-07-29 14:21:54.000000000 +0300
+++ check_reqs.js       2015-07-29 16:11:29.000000000 +0300
@@ -155,7 +155,7 @@
             // javac writes version info to stderr instead of stdout
             return tryCommand('javac -version', msg, true);
         }).then(function (output) {
-            return /^javac ((?:\d+\.)+(?:\d+))/i.exec(output)[1];
+            return /javac ((?:\d+\.)+(?:\d+))/i.exec(output)[1];
         });
     });
 };
{quote}

i. e. remove leading caret at the parsing regular expression, so it is not 
anchored to a beginning of a string.


> lib/check_reqs.js fails if javac returns an extra line
> ------------------------------------------------------
>
>                 Key: CB-9430
>                 URL: https://issues.apache.org/jira/browse/CB-9430
>             Project: Apache Cordova
>          Issue Type: Bug
>          Components: Android
>    Affects Versions: 4.1.0
>         Environment: ubuntu 14.04, cordova 5.1.1, cordova [email protected]
>            Reporter: Vadim Shlyakhov
>              Labels: patch
>
> lib/check_reqs.js fails if javac returns an extra line(s) instead of a single 
> line, for example: 
> {quote}
> Picked up _JAVA_OPTIONS: -Dawt.useSystemAAFontSettings=gasp
> javac 1.7.0_79
> {quote}
> instead of simply
> bq. javac 1.7.0_79
> The fix is quite simple:
> {quote}
> {noformat}
> --- check_reqs.js-    2015-07-29 14:21:54.000000000 +0300
> +++ check_reqs.js     2015-07-29 16:11:29.000000000 +0300
> @@ -155,7 +155,7 @@
>              // javac writes version info to stderr instead of stdout
>              return tryCommand('javac -version', msg, true);
>          }).then(function (output) {
> -            return /^javac ((?:\d+\.)+(?:\d+))/i.exec(output)[1];
> +            return /javac ((?:\d+\.)+(?:\d+))/i.exec(output)[1];
>          });
>      });
>  };
> {noformat}
> {quote}
> i. e. remove leading caret at the parsing regular expression, so it is not 
> anchored to a beginning of a string.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to