[
https://issues.apache.org/jira/browse/CB-9430?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14649211#comment-14649211
]
ASF GitHub Bot commented on CB-9430:
------------------------------------
GitHub user vladimir-kotikov opened a pull request:
https://github.com/apache/cordova-android/pull/204
CB-9430 Fixes check_reqs failure when javac returns an extra line
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/MSOpenTech/cordova-android CB-9430
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/cordova-android/pull/204.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #204
----
commit e5506d40bc444b468fbb04e4b9c3c9df6f3a0dec
Author: Vladimir Kotikov <[email protected]>
Date: 2015-07-31T13:37:21Z
CB-9430 Fixes check_reqs failure when javac returns an extra line
----
> lib/check_reqs.js fails if javac returns an extra line
> ------------------------------------------------------
>
> Key: CB-9430
> URL: https://issues.apache.org/jira/browse/CB-9430
> Project: Apache Cordova
> Issue Type: Bug
> Components: Android
> Affects Versions: 4.1.0
> Environment: ubuntu 14.04, cordova 5.1.1, cordova [email protected]
> Reporter: Vadim Shlyakhov
> Assignee: Vladimir Kotikov
> Labels: patch
>
> lib/check_reqs.js fails with
> bq. [TypeError: Cannot read property '1' of null]
> if javac returns an extra line(s) instead of a single line.
> For example:
> {quote}
> Picked up _JAVA_OPTIONS: -Dawt.useSystemAAFontSettings=gasp
> javac 1.7.0_79
> {quote}
> instead of simply
> bq. javac 1.7.0_79
> The fix is quite simple:
> {quote}
> {noformat}
> --- check_reqs.js- 2015-07-29 14:21:54.000000000 +0300
> +++ check_reqs.js 2015-07-29 16:11:29.000000000 +0300
> @@ -155,7 +155,7 @@
> // javac writes version info to stderr instead of stdout
> return tryCommand('javac -version', msg, true);
> }).then(function (output) {
> - return /^javac ((?:\d+\.)+(?:\d+))/i.exec(output)[1];
> + return /javac ((?:\d+\.)+(?:\d+))/i.exec(output)[1];
> });
> });
> };
> {noformat}
> {quote}
> i. e. remove leading caret at the parsing regular expression, so it is not
> anchored to a beginning of a string.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
