[
https://issues.apache.org/jira/browse/CB-9443?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14652500#comment-14652500
]
ASF GitHub Bot commented on CB-9443:
------------------------------------
Github user muratsu commented on a diff in the pull request:
https://github.com/apache/cordova-plugin-camera/pull/111#discussion_r36130273
--- Diff: src/windows/CameraProxy.js ---
@@ -696,21 +696,22 @@ function
takePictureFromCameraWindows(successCallback, errorCallback, args) {
// decide which max pixels should be supported by targetWidth or
targetHeight.
var maxRes = null;
var UIMaxRes = WMCapture.CameraCaptureUIMaxPhotoResolution;
+ var totalPixels = targetWidth * targetHeight;
switch (true) {
--- End diff --
didn't notice `switch (true)` was just correcting the case params but wow -
haha. definetely turning this to a `if/else`
> Windows camera picks incorrect maxResolution
> --------------------------------------------
>
> Key: CB-9443
> URL: https://issues.apache.org/jira/browse/CB-9443
> Project: Apache Cordova
> Issue Type: Bug
> Components: Plugin Camera
> Environment: Windows Desktop, Windows Phone 10
> Reporter: Murat Sutunc
> Assignee: Murat Sutunc
> Labels: Windows
>
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
