[
https://issues.apache.org/jira/browse/CB-8627?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14682041#comment-14682041
]
ASF GitHub Bot commented on CB-8627:
------------------------------------
Github user robpaveza commented on a diff in the pull request:
https://github.com/apache/cordova-lib/pull/228#discussion_r36766275
--- Diff: cordova-lib/src/cordova/plugin.js ---
@@ -206,10 +178,41 @@ module.exports = function plugin(command, targets,
opts) {
}
}
- events.emit('verbose', 'Calling
plugman.install on plugin "' + dir + '" for platform "' + platform + '" with
options "' + JSON.stringify(options) + '"');
- return plugman.raw.install(platform,
platformRoot, path.basename(dir), pluginsDir, options);
+ events.emit('verbose', 'Calling
plugman.install on plugin "' + result.dest + '" for platform "' + platform + '"
with options "' + JSON.stringify(options) + '"');
+ return plugman.raw.install(platform,
platformRoot, path.basename(result.dest), pluginsDir, options);
});
- }, Q());
+ }, Q()).then(function(){
+ return Q(result);
+ });
+ })
+ .then(function(result){
+ metadata.save_fetch_metadata(pluginsDir,
result.pinfo.id, { source: result.fetchJsonSource, variables:
opts.cli_variables, is_top_level: true });
+ return Q(result.dest);
+ })
+ .then(function(dir){
+ // save to config.xml
+ if(saveToConfigXmlOn(config_json,opts)){
--- End diff --
Usage: Function name `saveToConfigXmlOn` implies that it performs the
saving, but your branch seems to do so. Perhaps rename to
`shouldSaveToConfigXml`.
> 'cordova plugin add git_url' erroneously updates fetch.json even when the
> 'add operation fails'
> -----------------------------------------------------------------------------------------------
>
> Key: CB-8627
> URL: https://issues.apache.org/jira/browse/CB-8627
> Project: Apache Cordova
> Issue Type: Bug
> Components: CLI
> Reporter: Omar Mefire
> Assignee: Omar Mefire
>
> - cordova plugin add https://github.com/Wizcorp/phonegap-facebook-plugin.git
> This results in fetch.json being updated with the plugin info even though
> the plugin installation failed. It should not be the case.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
