[
https://issues.apache.org/jira/browse/CB-9505?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14701105#comment-14701105
]
ASF GitHub Bot commented on CB-9505:
------------------------------------
GitHub user vladimir-kotikov opened a pull request:
https://github.com/apache/cordova-js/pull/126
CB-9505 Correct plugin modules loading within browserify flow
This PR solves problem with a lot of plugins, which uses `js-module` tags
with `merges target=""`. Such modules are not loaded correctly, so, for
example, plugin proxies on windows platform are not available at runtime.
Instead of injecting `modulemapper` methods and `require` calls into
bundle, this PR assumes that bundled plugins modules will be loaded by special
'browserify' version of `cordova/pluginloader` (see below)
This fixes https://issues.apache.org/jira/browse/CB-9505
This PR needs to be merged along with corresponding PR to cordova-lib:
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/MSOpenTech/cordova-js CB-9505
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/cordova-js/pull/126.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #126
----
commit 2ac33863a05548c092c8471f12a9012cee485583
Author: Vladimir Kotikov <[email protected]>
Date: 2015-08-18T10:36:53Z
CB-9505 Correct plugin modules loading within browserify flow
----
> Some plugins on windows platform do not loaded correctly using browserify
> -------------------------------------------------------------------------
>
> Key: CB-9505
> URL: https://issues.apache.org/jira/browse/CB-9505
> Project: Apache Cordova
> Issue Type: Bug
> Reporter: Vladimir Kotikov
> Assignee: Vladimir Kotikov
> Labels: browserify, mobilespec, windows
>
> There is some issues with Windows plugins, which makes multiple tests to
> fail. The most of these issues are related to incorrect usage of
> `clobbers/merges` tags instead of `runs` in plugin definition. This causes
> plugins' proxies to not to register, so native functionality is not available
> to app. Some of plugins affected by this issue:
> # contacts
> # device
> # device-motion
> # device-orientation
> # file-transfer
> # media
> # network-information
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
