[
https://issues.apache.org/jira/browse/CB-9579?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14723439#comment-14723439
]
ASF GitHub Bot commented on CB-9579:
------------------------------------
GitHub user alsorokin opened a pull request:
https://github.com/apache/cordova-plugin-contacts/pull/74
CB-9579 Fixed failed tests when "DeleteMe" contact already exists
https://issues.apache.org/jira/browse/CB-9579
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/MSOpenTech/cordova-plugin-contacts CB-9579
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/cordova-plugin-contacts/pull/74.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #74
----
commit d51590c4bf873e292adbc4c32f06896967c25059
Author: Alexander Sorokin <[email protected]>
Date: 2015-08-31T14:05:58Z
CB-9579 Fixed failed tests when "DeleteMe" contact already exists
----
> contacts.spec.24 fails if there is already "DeleteMe" contact(s) present on
> device
> ----------------------------------------------------------------------------------
>
> Key: CB-9579
> URL: https://issues.apache.org/jira/browse/CB-9579
> Project: Apache Cordova
> Issue Type: Bug
> Components: Plugin Contacts
> Affects Versions: Master
> Reporter: Alexander Sorokin
> Assignee: Alexander Sorokin
>
> 1. Create a contact with "DeleteMe" name
> 2. Run contacts tests
> {noformat}
> cordova-plugin-contacts-tests.tests >> Contacts (navigator.contacts)
> Round trip Contact tests (creating + save + delete + find). contacts.spec.24
> Creating, saving, finding a contact should work, removing it should work,
> after which we should not be able to find it, and we should not be able to
> delete it again.
> Expected 3 to be 1.
> Error: Expected 3 to be 1.
> at stack
> (file:///android_asset/www/cdvtests/jasmine-2.2.0/jasmine.js:1455:17)
> at buildExpectationResult
> (file:///android_asset/www/cdvtests/jasmine-2.2.0/jasmine.js:1425:14)
> at Spec.Env.expectationResultFactory
> (file:///android_asset/www/cdvtests/jasmine-2.2.0/jasmine.js:572:18)
> at Spec.addExpectationResult
> (file:///android_asset/www/cdvtests/jasmine-2.2.0/jasmine.js:321:34)
> at Expectation.addExpectationResult
> (file:///android_asset/www/cdvtests/jasmine-2.2.0/jasmine.js:516:21)
> at Expectation.toBe
> (file:///android_asset/www/cdvtests/jasmine-2.2.0/jasmine.js:1379:12)
> at findWin
> (file:///android_asset/www/plugins/cordova-plugin-contacts-tests/tests.js:394:41)
> at win
> (file:///android_asset/www/plugins/cordova-plugin-contacts/www/contacts.js:56:17)
> at Object.cordova.callbackFromNative
> (file:///android_asset/www/cordova.js:293:58)
> at processMessage
> (file:///android_asset/www/cordova.js:1081:17)
> Expected 2 to be 0.
> Error: Expected 2 to be 0.
> at stack
> (file:///android_asset/www/cdvtests/jasmine-2.2.0/jasmine.js:1455:17)
> at buildExpectationResult
> (file:///android_asset/www/cdvtests/jasmine-2.2.0/jasmine.js:1425:14)
> at Spec.Env.expectationResultFactory
> (file:///android_asset/www/cdvtests/jasmine-2.2.0/jasmine.js:572:18)
> at Spec.addExpectationResult
> (file:///android_asset/www/cdvtests/jasmine-2.2.0/jasmine.js:321:34)
> at Expectation.addExpectationResult
> (file:///android_asset/www/cdvtests/jasmine-2.2.0/jasmine.js:516:21)
> at Expectation.toBe
> (file:///android_asset/www/cdvtests/jasmine-2.2.0/jasmine.js:1379:12)
> at findWinAgain
> (file:///android_asset/www/plugins/cordova-plugin-contacts-tests/tests.js:399:51)
> at win
> (file:///android_asset/www/plugins/cordova-plugin-contacts/www/contacts.js:56:17)
> at Object.cordova.callbackFromNative
> (file:///android_asset/www/cordova.js:293:58)
> at processMessage
> (file:///android_asset/www/cordova.js:1081:17)
> {noformat}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
