[
https://issues.apache.org/jira/browse/CB-9354?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14723512#comment-14723512
]
ASF GitHub Bot commented on CB-9354:
------------------------------------
Github user vladimir-kotikov commented on the pull request:
https://github.com/apache/cordova-lib/pull/256#issuecomment-136397624
@m1r4ge, tested and confirm that this works. However, there is already a
`nodeEqual` method (see
https://github.com/apache/cordova-lib/blob/master/cordova-lib/src/plugman/util/plist-helpers.js#L83),
which compares nodes in a more correct way. Consider using it instead of
string comparison.
Also please file an Apache ICLA, if possible
(http://www.apache.org/dev/new-committers-guide.html#cla). Thanks.
> Incorrect array merging in *-Info.plist
> ---------------------------------------
>
> Key: CB-9354
> URL: https://issues.apache.org/jira/browse/CB-9354
> Project: Apache Cordova
> Issue Type: Bug
> Components: CLI, CordovaLib
> Affects Versions: 5.1.1
> Environment: Mac OS X Yosemity
> Reporter: Sviatoslav Grebenchucov
>
> After installing
> [phonegap-facebook-plugin|https://github.com/Wizcorp/phonegap-facebook-plugin.git]
> each consequent run of 'cordova prepare' results in creating a duplicate of
> the dictionary containing Facebook custom url scheme.
> After plugin installation App-Info.plist looks like:
> {code:xml}
> <key>CFBundleURLTypes</key>
> <array>
> <dict>
> <key>CFBundleURLSchemes</key>
> <array>
> <string>fb123456789</string>
> </array>
> </dict>
> </array>
> {code}
> After 'cordova prepare':
> {code:xml}
> <key>CFBundleURLTypes</key>
> <array>
> <dict>
> <key>CFBundleURLSchemes</key>
> <array>
> <string>fb123456789</string>
> </array>
> </dict>
> <dict>
> <key>CFBundleURLSchemes</key>
> <array>
> <string>fb123456789</string>
> </array>
> </dict>
> </array>
> {code}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
