[
https://issues.apache.org/jira/browse/CB-8993?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14723885#comment-14723885
]
ASF GitHub Bot commented on CB-8993:
------------------------------------
Github user omefire commented on the pull request:
https://github.com/apache/cordova-lib/pull/292#issuecomment-136472329
Thanks for suggesting these changes.
However, I have a suggestion :
As it currently stands, it seems like adding adding a platform or restoring
from config.xml is broken.
It doesn't handle cases where the searchpath comes from config.json or the
case when the searchpath could be an array of multiple paths.
I propose we include that fix with this one. What do you think ?
For references, see : [Handling searchpaths as string or
array](https://github.com/apache/cordova-lib/blob/41765f1fd7393be1fff2b39ba7cf00b5bf6f1ef1/cordova-lib/src/cordova/plugin.js#L97).
> Plugin restore ignores search path
> ----------------------------------
>
> Key: CB-8993
> URL: https://issues.apache.org/jira/browse/CB-8993
> Project: Apache Cordova
> Issue Type: Bug
> Components: CLI
> Reporter: Marcus Pridham
> Assignee: Alexander Sorokin
> Fix For: 5.1.2
>
>
> If I run the command:
> cordova prepare --searchpath ~/cordova-plugins
> I would expect the CLI to try restore plugins in the config.xml from the
> provided searchpath. Currently this parameter is ignored.
> I can get this to work if I modify the opts variable in cli.js and add:
> searchpath : args.searchpath,
> https://github.com/apache/cordova-cli/blob/master/src/cli.js#L179
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
