[ 
https://issues.apache.org/jira/browse/CB-9610?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14733592#comment-14733592
 ] 

ASF GitHub Bot commented on CB-9610:
------------------------------------

Github user jcesarmobile commented on the pull request:

    https://github.com/apache/cordova-ios/pull/157#issuecomment-138280386
  
    shouldn't the ```- (NSUInteger)application:(UIApplication*)application 
supportedInterfaceOrientationsForWindow:(UIWindow*)window``` still be needed 
for iOS 8 and previous?
    
    why not something like this?
    ```
    #if __IPHONE_OS_VERSION_MAX_ALLOWED < 90000  
    - (NSUInteger)application:(UIApplication*)application 
supportedInterfaceOrientationsForWindow:(UIWindow*)window
    #else  
    - (UIInterfaceOrientationMask)application:(UIApplication*)application 
supportedInterfaceOrientationsForWindow:(UIWindow*)window
    #endif 
    ```


> Fix warning in cordova-ios under Xcode 7
> ----------------------------------------
>
>                 Key: CB-9610
>                 URL: https://issues.apache.org/jira/browse/CB-9610
>             Project: Apache Cordova
>          Issue Type: Bug
>          Components: iOS
>            Reporter: Shazron Abdullah
>              Labels: cordova-ios-4.0.x
>
> Pull request: https://github.com/apache/cordova-ios/pull/157
> Note: make sure the code still compiles under Xcode 6.4.
> Also, compile under iOS 9 SDK, and deploy to an iOS 8 device. Make sure it 
> doesn't crash.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

Reply via email to