[
https://issues.apache.org/jira/browse/CB-9601?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14734685#comment-14734685
]
ASF GitHub Bot commented on CB-9601:
------------------------------------
GitHub user sgrebnov opened a pull request:
https://github.com/apache/cordova-lib/pull/300
CB-9601 Fix <framework>.versions support on Windows after semver update
https://issues.apache.org/jira/browse/CB-9601
Adds logic to convert Windows specific four-digits version to three-digits
semver compatible version.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/MSOpenTech/cordova-lib CB-9601
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/cordova-lib/pull/300.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #300
----
commit 04310fb70e953be48b9123697b54d661c81cca8e
Author: sgrebnov <[email protected]>
Date: 2015-09-03T16:10:13Z
CB-9601 Fix <framework>.versions support on Windows after semver update
----
> Fix <framework>.versions support on Windows after semver update
> ---------------------------------------------------------------
>
> Key: CB-9601
> URL: https://issues.apache.org/jira/browse/CB-9601
> Project: Apache Cordova
> Issue Type: Bug
> Components: CordovaLib, Plugman, Windows
> Reporter: Sergey Grebnov
> Assignee: Sergey Grebnov
> Labels: cordova-lib, plugman, windows
>
> After semver dependency update in [email protected]
> (https://github.com/apache/cordova-lib/commit/bed6d3a201e0193b2ffdb60fa6de74de0c870cec)
>
> the following version attribute is handled incorrectly and dependency is not
> installed to Windows10 project (CordovaApp.Windows10.jsproj)
> {code}
> <framework src="windows81/bin/TestWinmd.winmd" versions=">=8.1" />
> {code}
> This works correct if I install Cordova 5.1.1 or manually change semver
> version back to 2.1.0
> Repro step:
> 1. Add windows platform to cordova app
> 2. Add plugin containt the following element
> {code}
> <framework src="windows81/bin/TestWinmd.winmd" versions=">=8.1" />
> {code}
> 3. Expected: TestWinmd.winmd is added to CordovaApp.Windows10.jsproj (and
> also to CordovaApp.Phone.jsproj, CordovaApp.Windows.jsproj)
> 4. Actual: TestWinmd.winmd is added only to CordovaApp.Phone.jsproj,
> CordovaApp.Windows.jsproj
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
