[ 
https://issues.apache.org/jira/browse/CB-9617?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14737047#comment-14737047
 ] 

ASF GitHub Bot commented on CB-9617:
------------------------------------

GitHub user vladimir-kotikov opened a pull request:

    https://github.com/apache/cordova-lib/pull/304

    CB-9617 Do not restore plugins immediately after plugin removal

    
https://github.com/apache/cordova-lib/commit/14675051c400a6811a6c6171fbf92f3475244630
 introduced `cordova.prepare` call after each plugin uninstallation (see 
[CB-9617](https://issues.apache.org/jira/browse/CB-9617)). This results in a 
weird behaviour, when removed plugin immediately restored if it was saved in 
config.xml.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/MSOpenTech/cordova-lib CB-9617

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/cordova-lib/pull/304.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #304
    
----
commit 28f50131ef14615157c56fae748557cda30f9e00
Author: Vladimir Kotikov <v-vlk...@microsoft.com>
Date:   2015-09-09T15:25:10Z

    CB-9617 Do not restore plugins after plugin removal

----


> Add plugin or platform doesn't create www/plugins folder
> --------------------------------------------------------
>
>                 Key: CB-9617
>                 URL: https://issues.apache.org/jira/browse/CB-9617
>             Project: Apache Cordova
>          Issue Type: Bug
>          Components: CordovaLib
>    Affects Versions: Master
>            Reporter: Tim Barham
>            Assignee: Vladimir Kotikov
>              Labels: PlatformApi
>
> Since the new Platform API polyfill, adding a platform or a plugin doesn't 
> create the www/plugins folder, or copy the plugin/plugins there.
> *Repo adding a platform:*
> 1. Create a new blank project
> 2. {{cordova plugin add cordova-plugin-camera}}
> 3. {{cordova platform add browser}}
> *Expected:*
> The {{platforms/browser/www}} folder contains a {{plugins}} folder that 
> contains a {{cordova-plugin-camera}} folder.
> *Actual:*
> It doesn't.
> *Repo adding a plugin:*
> If you add the platform before the plugin, the same result occurs. Also, 
> consider this scenario:
> 1. Create a new blank project
> 2. {{cordova platform add browser}}
> 3. {{cordova plugin add cordova-plugin-camera}}
> 4. {{cordova prepare}}
> 5. {{cordova plugin add cordova-plugin-device}}
> *Expected:*
> The platforms\browser\www\plugins folder should contain folders for 
> {{cordova-plugin-camera}} and {{cordova-plugin-device}}.
> *Actual:*
> It only contains a folder for {{cordova-plugin-camera}}.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

Reply via email to