[ 
https://issues.apache.org/jira/browse/CB-9636?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14743652#comment-14743652
 ] 

ASF subversion and git services commented on CB-9636:
-----------------------------------------------------

Commit a56ff479fcd9053e141ef4bb3779491987b49bc4 in cordova-ios's branch 
refs/heads/CB-9328 from [~shazron]
[ https://git-wip-us.apache.org/repos/asf?p=cordova-ios.git;h=a56ff47 ]

CB-9636 - only load a WebView engine if the url to load passes the engine's 
canLoadRequest filter


> Plugin should detect at runtime iOS 8 and use of file:// url and present an 
> error
> ---------------------------------------------------------------------------------
>
>                 Key: CB-9636
>                 URL: https://issues.apache.org/jira/browse/CB-9636
>             Project: Apache Cordova
>          Issue Type: Bug
>          Components: iOS, Plugin WKWebViewEngine
>            Reporter: Shazron Abdullah
>            Assignee: Shazron Abdullah
>              Labels: cordova-ios-4.0.x
>
> Check whether it's a file url and iOS 8, and use loadHTMLString to present an 
> error instead (and NSLog it).
> This is unfortunate and shouldn't happen but we need to catch it nonetheless.
> The WebView engine load will fail if these conditions are fulfilled:
> 1. iOS 8 
> 2. file:// url
> 3. current WebView engine is a WKWebView
> This determination should be delegated to the WebView engine itself. There 
> needs to be another method in the CDVWebViewEngineProtocol -- 
> canLoadRequest:(NSURLRequest*)
> If the WebViewEngine cannot load the request, we fall back to the UIWebView 
> engine. This might cause a UI glitch that is undesirable when we need to 
> replace WebView engines -- this assumption needs to be tested.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to