[
https://issues.apache.org/jira/browse/CB-8936?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14903268#comment-14903268
]
ASF GitHub Bot commented on CB-8936:
------------------------------------
Github user dblotsky commented on a diff in the pull request:
https://github.com/apache/cordova-medic/pull/64#discussion_r40131491
--- Diff: medic/medic-log.js ---
@@ -63,10 +63,14 @@ function logIOS() {
});
}
-function logWindows() {
+function logWindows(timeout) {
var logScriptPath = path.join("mobilespec", "platforms", "windows",
"cordova", "log.bat");
if (fs.existsSync(logScriptPath)) {
- shelljs.exec(logScriptPath + " --dump --mins 15", function (code,
output) {
+ var mins = 15;
+ if (timeout) {
+ mins = Math.ceil(timeout / 60);
--- End diff --
A few notes:
- Please add a small constant (~2 min) to the time so that we also capture
anything that happened before the run
- Please factor out the default 15 mins into a constant
- Please add a function to convert minutes to seconds, so it's easier to
read (i.e. `mins = sec2min(timeout)`)
> Surface platform-specific logs in buildbot
> ------------------------------------------
>
> Key: CB-8936
> URL: https://issues.apache.org/jira/browse/CB-8936
> Project: Apache Cordova
> Issue Type: Task
> Components: Medic
> Reporter: Alexander Sorokin
> Assignee: Alexander Sorokin
>
> Platform specific logs (e.g. logcat for android, stderr.log and stdin.log for
> iOS etc.) should be gathered and displayed in buildbot.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
