[
https://issues.apache.org/jira/browse/CB-9608?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14904859#comment-14904859
]
ASF GitHub Bot commented on CB-9608:
------------------------------------
GitHub user daserge opened a pull request:
https://github.com/apache/cordova-android/pull/217
CB-9608 cordova-android no longer builds on Node 0.10 or below
Replaced `path.isAbsolute` usage with `path.resolve`.
[Jira issue](https://issues.apache.org/jira/browse/CB-9608)
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/MSOpenTech/cordova-android CB-9608
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/cordova-android/pull/217.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #217
----
commit c32d47ad06e29a1fd3cbd3241b46d19bb1683692
Author: daserge <[email protected]>
Date: 2015-09-23T12:57:03Z
CB-9608 cordova-android no longer builds on Node 0.10 or below
Replaced path.isAbsolute usage with path.resolve
----
> cordova-android no longer builds on Node 0.10 or below
> ------------------------------------------------------
>
> Key: CB-9608
> URL: https://issues.apache.org/jira/browse/CB-9608
> Project: Apache Cordova
> Issue Type: Bug
> Affects Versions: Master
> Reporter: Matt Steele
> Assignee: Sergey Shakhnazarov
>
> cordova-android uses `path.isAbsolute` as part of its build script, which is
> only available on Node versions 0.12 and above.
> This commit (related to CB-9284) introduced the `isAbsolute` dependency:
> https://github.com/apache/cordova-android/commit/d3245a43d303b570daed1c2fc828deccbe306441
> Based on [this slack
> conversation|https://cordova.slack.com/archives/general/p1441150444000145],
> it looks like this resolution is to continue supporting 0.10, so we should
> find a way to remove `path.isAbsolute`. Here's one option:
> https://www.npmjs.com/package/path-is-absolute
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
