[
https://issues.apache.org/jira/browse/CB-9696?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14906038#comment-14906038
]
ASF GitHub Bot commented on CB-9696:
------------------------------------
GitHub user ttiurani opened a pull request:
https://github.com/apache/cordova-android/pull/218
CB-9696: Add possibility to use non-immersive fullscreen in all Andro…
…id versions
When setting the new preference "fullscreen-immersive" to false like this:
<preference name="fullscreen" value="true" />
<preference name="fullscreen-immersive" value="false" />
Cordova reverts to old fullscreen behaviour also on newer Android versions.
This fixes issue
CB-9696.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/ttiurani/cordova-android master
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/cordova-android/pull/218.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #218
----
commit b576c28686d431ffc219e4f753e83ae1334c9e92
Author: Timo Tiuraniemi <[email protected]>
Date: 2015-09-24T08:45:39Z
CB-9696: Add possibility to use non-immersive fullscreen in all Android
versions
When setting the new preference "fullscreen-immersive" to false like this:
<preference name="fullscreen" value="true" />
<preference name="fullscreen-immersive" value="false" />
Cordova reverts to old fullscreen behaviour also on newer Android versions.
This fixes issue
CB-9696.
----
> Add possibility to use non-immersive fullscreen in all Android versions
> -----------------------------------------------------------------------
>
> Key: CB-9696
> URL: https://issues.apache.org/jira/browse/CB-9696
> Project: Apache Cordova
> Issue Type: Improvement
> Components: Android
> Affects Versions: Master
> Reporter: Timo Tiuraniemi
> Priority: Minor
> Original Estimate: 1h
> Remaining Estimate: 1h
>
> Issue CB-8902 added a fullscreen immersive mode for Android version >=4.4
> Kitkat.
> As I commented on the issue, unfortunately this change broke my >=KitKat app.
> Immersive mode is significantly different from the old behavior:
> 1. Fullscreen in 4.1.1 is triggered later during boot than in 4.0.0, which
> cause my layout to slightly break as CSS is evaluated before fullscreen is
> ready.
> 2. When activating the keyboard, to navigation bar comes back. It didn't in
> 4.0.0. When I close the keyboard, the navigation bar doesn't get hidden but
> fullscreen is lost.
> I propose that we introduce a new setting "fullscreen-immersive" to turn
> immersive off, but keep fullscreen on like this:
> <preference name="fullscreen" value="true" />
> <preference name="fullscreen-immersive" value="false" />
> The new setting would default to true, making this change non-breaking for
> everyone.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
