Shazron Abdullah created CB-9737:
------------------------------------
Summary: (save flag) unit test failures for spec.14
Key: CB-9737
URL: https://issues.apache.org/jira/browse/CB-9737
Project: Apache Cordova
Issue Type: Bug
Components: CordovaLib
Reporter: Shazron Abdullah
Assignee: Shazron Abdullah
Priority: Critical
{code}
Failures:
1) (save flag) plugin add --save spec.14 should save variables
Message:
Expected null to be '123456789'.
Stacktrace:
Error: Expected null to be '123456789'.
at
/Users/shazron/Desktop/cordova-lib/cordova-lib/spec-cordova/save.spec.js:313:90
at _fulfilled
(/Users/shazron/Desktop/cordova-lib/cordova-lib/node_modules/q/q.js:787:54)
at self.promiseDispatch.done
(/Users/shazron/Desktop/cordova-lib/cordova-lib/node_modules/q/q.js:816:30)
at Promise.promise.promiseDispatch
(/Users/shazron/Desktop/cordova-lib/cordova-lib/node_modules/q/q.js:749:13)
at /Users/shazron/Desktop/cordova-lib/cordova-lib/node_modules/q/q.js:509:49
at flush
(/Users/shazron/Desktop/cordova-lib/cordova-lib/node_modules/q/q.js:108:17)
at process._tickCallback (node.js:355:11)
2) (save flag) plugin add --save spec.14 should save variables
Message:
Expected null to be 'myApplication'.
Stacktrace:
Error: Expected null to be 'myApplication'.
at
/Users/shazron/Desktop/cordova-lib/cordova-lib/spec-cordova/save.spec.js:314:92
at _fulfilled
(/Users/shazron/Desktop/cordova-lib/cordova-lib/node_modules/q/q.js:787:54)
at self.promiseDispatch.done
(/Users/shazron/Desktop/cordova-lib/cordova-lib/node_modules/q/q.js:816:30)
at Promise.promise.promiseDispatch
(/Users/shazron/Desktop/cordova-lib/cordova-lib/node_modules/q/q.js:749:13)
at /Users/shazron/Desktop/cordova-lib/cordova-lib/node_modules/q/q.js:509:49
at flush
(/Users/shazron/Desktop/cordova-lib/cordova-lib/node_modules/q/q.js:108:17)
at process._tickCallback (node.js:355:11)
{code}
This change in the phonegap-facebook-plugin broke the test:
https://github.com/Wizcorp/phonegap-facebook-plugin/commit/a2f6dbb80a54eff29a0e09836aebf0dd905fd60a
Fix is to change the plugin id to "phonegap-facebook-plugin":
https://github.com/apache/cordova-lib/blob/07271a5c6162c0b2bee55e1ea23f91ebdfbbb34c/cordova-lib/spec-cordova/save.spec.js#L52
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org
