[ 
https://issues.apache.org/jira/browse/CB-9719?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14942504#comment-14942504
 ] 

ASF GitHub Bot commented on CB-9719:
------------------------------------

Github user csantanapr commented on the pull request:

    https://github.com/apache/cordova-ios/pull/170#issuecomment-145299566
  
    I did some investigation today, I found the reason why putting 
    CLANG_ENABLE_MODULES = NO
    in build.xcconfig doesn't get reflected, is because build.xcconfig is for 
Project, not the Target, the Project file is set to Yes, and Project file has 
higher precedence than Project xcconfig
    
    For the variable assingment to be able to work it needs to be set in 
Target's release/build or extras xcconfig
    
    There is another value that also fixes our problem with a framework 
referring to a non-module header/class from CordovaLib
    CLANG_ALLOW_NON_MODULAR_INCLUDES_IN_FRAMEWORK_MODULES = YES
    
    From looking at all levels in XCode, it looks like the iOS Platform default 
is:
    CLANG_ENABLE_MODULES = NO and 
CLANG_ALLOW_NON_MODULAR_INCLUDES_IN_FRAMEWORK_MODULES = NO
    But XCode 7 when it creates a new projects, overwrites the default of one 
of them to CLANG_ENABLE_MODULES = YES
    
    It might be safer to set 
    CLANG_ALLOW_NON_MODULAR_INCLUDES_IN_FRAMEWORK_MODULES = YES
    which I think is more closer to the compile error that we are getting, and 
maybe has less side effects.
    
    By Google Power I discover this page, explains variable assignment 
precedence:
    http://pewpewthespells.com/blog/xcconfig_guide.html
    
    What you all think?
    And what would be the best to assign it? Project (build.xcconfig) or Target 
(build-debug.xcconfig and build-release.xcconfig)
    We could use extras but I would like to leave extra empty for the 
developer/user to overwrite values from Target and Project xcconfig 
programmatically
    
    
    
    



> Xcode build error in framework with CordovaLib as a dependency
> --------------------------------------------------------------
>
>                 Key: CB-9719
>                 URL: https://issues.apache.org/jira/browse/CB-9719
>             Project: Apache Cordova
>          Issue Type: Bug
>          Components: iOS
>    Affects Versions: Master
>            Reporter: Edna Morales
>            Assignee: Edna Morales
>              Labels: cordova-ios-4.0.x
>
> We have a .framework that depends on CordovaLib and has an import statement 
> in one of our header files:
> #import <Cordova/CDVViewController.h>
> We get an error when we build the application:
> Include of non-modular header inside framework module 
> 'IBMMobileFirstPlatformFoundationHybrid.WLCordovaAppDelegate'
> I'm not getting an error with any other import statements like:
> #import <UIKit/UIKit.h>
> If I change the project setting 'Enable Modules (C and Objective-C)' to No, 
> the error goes away



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

Reply via email to