[
https://issues.apache.org/jira/browse/CB-9763?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14946907#comment-14946907
]
ASF GitHub Bot commented on CB-9763:
------------------------------------
GitHub user vldmrrr opened a pull request:
https://github.com/apache/cordova-plugin-file/pull/137
CB-9763: added handling for encoding exception in readAsText on Windows
readAsText on windows uses
Windows.Security.Cryptography.CryptographicBuffer.convertBinaryToString to
convert buffer to requested exception. When such conversion can not be mayed,
it thows exception, that is currently not handled. The function shall fail with
FileError.ENCODING_ERR instead.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/vldmrrr/cordova-plugin-file CB-9763
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/cordova-plugin-file/pull/137.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #137
----
commit c378dc61e69c905b09c793711959f3b687ecb078
Author: vladimir <vladimir@elitebook>
Date: 2015-10-07T14:09:52Z
Fail with FileError.ENCODING_ERR on encoding exception.
----
> Plugin File:Windows:readAsText may throw uncought encoding excpetion
> --------------------------------------------------------------------
>
> Key: CB-9763
> URL: https://issues.apache.org/jira/browse/CB-9763
> Project: Apache Cordova
> Issue Type: Bug
> Components: Plugin File
> Affects Versions: 3.5.0
> Environment: Windows
> Reporter: vldmrrrr
>
> readAsText on windows uses
> Windows.Security.Cryptography.CryptographicBuffer.convertBinaryToString to
> convert buffer to requested exception. When such conversion can not be mayed,
> it thows exception, that is currently not handled. The function shall fail
> with FileError.ENCODING_ERR instead.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
