[ 
https://issues.apache.org/jira/browse/CB-9490?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14952896#comment-14952896
 ] 

ASF GitHub Bot commented on CB-9490:
------------------------------------

Github user sgrebnov commented on a diff in the pull request:

    
https://github.com/apache/cordova-plugin-camera/pull/115#discussion_r41742198
  
    --- Diff: src/android/CameraLauncher.java ---
    @@ -386,12 +387,10 @@ private void processResultFromCamera(int destType, 
Intent intent) throws IOExcep
                 FileHelper.stripFileProtocol(this.croppedUri.toString()) :
                 FileHelper.stripFileProtocol(this.imageUri.toString());
     
    -        if (this.encodingType == JPEG) {
    -            try {
    -                //We don't support PNG, so let's not pretend we do
    -                exif.createInFile(sourcePath);
    -                exif.readExifData();
    -                rotate = exif.getOrientation();
    +            //We don't support PNG, so let's not pretend we do
    --- End diff --
    
    I don't think this change should be in scope of this PR (I know there is a 
person working on .PNG support so this will just bring merge conflict) 


> LG G4 camera application saves photos when using destinationType DATA_URL
> -------------------------------------------------------------------------
>
>                 Key: CB-9490
>                 URL: https://issues.apache.org/jira/browse/CB-9490
>             Project: Apache Cordova
>          Issue Type: Bug
>          Components: Plugin Camera
>         Environment: LG G4, Android 5.1
>            Reporter: Cody Balos
>            Assignee: Cody Balos
>          Time Spent: 6h
>  Remaining Estimate: 0h
>
> So far this issue only happens on an LG G4 using the stock camera application:
> Using the camera plugin, with destinationType set to DATA_URL,
> the expected functionality is for the base64 string to be returned to the 
> javascript interface, and not saved to the file system without explicitly 
> saving it separately. Using the LG G4 stock camera application, all photos 
> are saved even when using destinationType DATA_URL if the retake option is 
> used. 
> The issue does not occur when using the Google Camera application or Camera 
> 360 (both on the Play Store). 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to