[
https://issues.apache.org/jira/browse/CB-7015?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14956259#comment-14956259
]
ASF GitHub Bot commented on CB-7015:
------------------------------------
Github user macdonst commented on the pull request:
https://github.com/apache/cordova-lib/pull/290#issuecomment-147934476
I'm not in favor of this PR being merged into master as I don't think we
should add the functionality CB-7015 asks for. There is no need to add a new
tag to support as the framework tag accomplishes exactly the same
functionality. Yes, this requires that your Android project use Gradle but
Gradle support for Cordova Android has been around for almost a year so it is
time to upgrade your Cordova projects to use it.
It doesn't make sense to add this code that duplicates functionality for a
build system that is deprecated. If we add this code we will be responsible for
testing and maintaining it going forward.
-1
> Support copying a lib-file from the SDK directory
> -------------------------------------------------
>
> Key: CB-7015
> URL: https://issues.apache.org/jira/browse/CB-7015
> Project: Apache Cordova
> Issue Type: New Feature
> Components: Plugman
> Reporter: Martin Bektchiev
> Assignee: Martin Bektchiev
> Priority: Minor
>
> Many plugins need to refer to JARs from the Android SDK. They currently embed
> a copy of the respective files in them and install it into the application's
> libs/ directory. This however might create incompatibility issues with other
> plugins which may use the same or dependent JARs.
> A good alternative would be to be able to specify a relative path to the SDK
> directory in <lib-file> as it is now possible with the <framework> element
> with custom=false.
> E.g.
> <source-file src="src/android/com/plugin/android-support-v13.jar"
> target-dir="libs/" />
> could become
> <lib-file src="extras/android/support/v13/android-support-v13.jar"
> custom="false" />
> in
> https://github.com/phonegap-build/PushPlugin/blob/54e59bce6092ec44fe2005c166350fd85e75449b/plugin.xml#L64
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
