Sergey Grebnov created CB-9821:
----------------------------------
Summary: Fix EventEmitter wrong usages
Key: CB-9821
URL: https://issues.apache.org/jira/browse/CB-9821
Project: Apache Cordova
Issue Type: Bug
Components: CordovaLib
Reporter: Sergey Grebnov
Assignee: Sergey Grebnov
I see some places where we use incorrect log level argument, like 'err' or
'debug' so those traces are ignored and not displayed or could be intercepted
by CordovaCLI/Plugman or other tools.
For example (we don't support 'debug'; the correct argument here is 'verbose'):
{code}
function getPluginsHookScripts(hook, opts) {
// args check
if (!hook) {
throw new Error('hook type is not specified');
}
// In case before_plugin_install, after_plugin_install,
before_plugin_uninstall hooks we receive opts.plugin and
// retrieve scripts exclusive for this plugin.
if(opts.plugin) {
events.emit('debug', 'Executing "' + hook + '" hook for "' +
opts.plugin.id + '" on ' + opts.plugin.platform + '.');
// if plugin hook is not run for specific platform then use all
available platforms
return getPluginScriptFiles(opts.plugin, hook, opts.plugin.platform ?
[opts.plugin.platform] : opts.cordova.platforms);
}
events.emit('debug', 'Executing "' + hook + '" hook for all plugins.');
return getAllPluginsHookScriptFiles(hook, opts);
}
{code}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
