[
https://issues.apache.org/jira/browse/CB-9821?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14963083#comment-14963083
]
ASF GitHub Bot commented on CB-9821:
------------------------------------
GitHub user sgrebnov opened a pull request:
https://github.com/apache/cordova-lib/pull/325
CB-9821 Fix EventEmitter incorrect trace level usages
https://issues.apache.org/jira/browse/CB-9821
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/MSOpenTech/cordova-lib CB-9821
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/cordova-lib/pull/325.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #325
----
commit 90af84ff5e1a3fb28270068c1f3a3b6433a4298c
Author: sgrebnov <[email protected]>
Date: 2015-10-19T09:49:32Z
CB-9821 Fix EventEmitter incorrect trace level usages
----
> Fix EventEmitter incorrect trace level usages
> ---------------------------------------------
>
> Key: CB-9821
> URL: https://issues.apache.org/jira/browse/CB-9821
> Project: Apache Cordova
> Issue Type: Bug
> Components: CordovaLib
> Reporter: Sergey Grebnov
> Assignee: Sergey Grebnov
> Labels: cordova-lib
>
> I see some places where we use incorrect log level argument, like 'err' or
> 'debug' so those traces are ignored and not displayed or could be intercepted
> by CordovaCLI/Plugman or other tools.
> For example (we don't support 'debug'; the correct argument here is
> 'verbose'):
> {code}
> function getPluginsHookScripts(hook, opts) {
> // args check
> if (!hook) {
> throw new Error('hook type is not specified');
> }
> // In case before_plugin_install, after_plugin_install,
> before_plugin_uninstall hooks we receive opts.plugin and
> // retrieve scripts exclusive for this plugin.
> if(opts.plugin) {
> events.emit('debug', 'Executing "' + hook + '" hook for "' +
> opts.plugin.id + '" on ' + opts.plugin.platform + '.');
> // if plugin hook is not run for specific platform then use all
> available platforms
> return getPluginScriptFiles(opts.plugin, hook, opts.plugin.platform
> ? [opts.plugin.platform] : opts.cordova.platforms);
> }
> events.emit('debug', 'Executing "' + hook + '" hook for all plugins.');
> return getAllPluginsHookScriptFiles(hook, opts);
> }
> {code}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
