[
https://issues.apache.org/jira/browse/CB-9843?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14968959#comment-14968959
]
ASF GitHub Bot commented on CB-9843:
------------------------------------
Github user daserge commented on a diff in the pull request:
https://github.com/apache/cordova-plugin-file-transfer/pull/106#discussion_r42734873
--- Diff: src/wp/FileTransfer.cs ---
@@ -775,11 +775,8 @@ private void downloadCallback(IAsyncResult
asynchronousResult)
}
catch (WebException webex)
{
- // TODO: probably need better work here to properly
respond with all http status codes back to JS
- // Right now am jumping through hoops just to detect 404.
HttpWebResponse response = (HttpWebResponse)webex.Response;
- if ((webex.Status == WebExceptionStatus.ProtocolError &&
response.StatusCode == HttpStatusCode.NotFound)
- || webex.Status == WebExceptionStatus.UnknownError)
+ if ((webex.Status == WebExceptionStatus.ProtocolError) ||
(webex.Status == WebExceptionStatus.UnknownError))
--- End diff --
Please remove excess brackets.
> filetransfer.spec.12 failure on wp8
> -----------------------------------
>
> Key: CB-9843
> URL: https://issues.apache.org/jira/browse/CB-9843
> Project: Apache Cordova
> Issue Type: Bug
> Components: Plugin File Transfer
> Affects Versions: Master
> Reporter: Alexander Sorokin
> Assignee: Alexander Sorokin
>
> There is a file transfer plugin failure on wp8 platform:
> {noformat}
> cordova-plugin-file-transfer-tests.tests >> FileTransfer methods download
> filetransfer.spec.12 should get http status on failure
> Expected 3 to be 1.
> Error: Expected 3 to be 1.
> at stack
> (x-wmapp0:www/cdvtests/jasmine-2.2.0/jasmine.js:1455:11)
> at buildExpectationResult
> (x-wmapp0:www/cdvtests/jasmine-2.2.0/jasmine.js:1422:5)
> at expectationResultFactory
> (x-wmapp0:www/cdvtests/jasmine-2.2.0/jasmine.js:572:11)
> at addExpectationResult
> (x-wmapp0:www/cdvtests/jasmine-2.2.0/jasmine.js:321:5)
> at addExpectationResult
> (x-wmapp0:www/cdvtests/jasmine-2.2.0/jasmine.js:516:9)
> at Anonymous function
> (x-wmapp0:www/cdvtests/jasmine-2.2.0/jasmine.js:1379:7)
> at downloadFail
> (x-wmapp0:www/cdvtests/../plugins/cordova-plugin-file-transfer-tests/tests.js:507:25)
> at errorCallback
> (x-wmapp0:www/cdvtests/../plugins/cordova-plugin-file-transfer/www/FileTransfer.js:221:9)
> at callbackFromNative
> (x-wmapp0:www/cdvtests/../cordova.js:295:38)
> at callbackError (x-wmapp0:www/cdvtests/../cordova.js:282:9)
> {noformat}
> wp8 platform does not make a difference between 404 and unknown host so the
> plugin returns CONNECTION_ERR and not FILE_NOT_FOUND_ERR
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
