[
https://issues.apache.org/jira/browse/CB-9844?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14976005#comment-14976005
]
ASF GitHub Bot commented on CB-9844:
------------------------------------
GitHub user vladimir-kotikov opened a pull request:
https://github.com/apache/cordova-android/pull/233
CB-9844 Remove old .java after renaming activity
This is a port of https://github.com/apache/cordova-lib/pull/328 to
cordova-android. Need to be done in two places since the `prepare` logic was
moved to platform.
More details on JIRA:
[CB-9844](https://issues.apache.org/jira/browse/CB-9844) and
[CB-9736](https://issues.apache.org/jira/browse/CB-9736)
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/MSOpenTech/cordova-android CB-9844
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/cordova-android/pull/233.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #233
----
commit c1b389ad9b75c7029acc33a532f5626692235daf
Author: Vladimir Kotikov <[email protected]>
Date: 2015-10-27T06:12:47Z
CB-9844 Remove old .java after renaming activity
----
> 2 main activities are generated when android package name is specified
> ----------------------------------------------------------------------
>
> Key: CB-9844
> URL: https://issues.apache.org/jira/browse/CB-9844
> Project: Apache Cordova
> Issue Type: Bug
> Components: Android
> Affects Versions: 5.0.0
> Reporter: Gorkem ERCAN
> Assignee: Gorkem ERCAN
> Priority: Minor
>
> If android-packageName is specified on the config.xml two main activity
> classes are generated. One with with the package name as specified on id
> attribute and one with the value of android-packageName. This is because the
> old package name is not removed when the new one is generated [1].
> This has been fixed for Cordova CLI but needs to be fixed on Android because
> the logic has moved.
> [1]
> https://github.com/apache/cordova-android/blob/master/bin/templates/cordova/lib/prepare.js#L156
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]