[
https://issues.apache.org/jira/browse/CB-4596?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14977460#comment-14977460
]
ASF GitHub Bot commented on CB-4596:
------------------------------------
GitHub user purplecabbage opened a pull request:
https://github.com/apache/cordova-plugin-geolocation/pull/55
CB-4596 Documentation is not consistent for timestamp types
Treats all timestamp objects as DOMTimeStamp objects which are ever
increasing msecs.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/purplecabbage/cordova-plugin-geolocation
CB-4596
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/cordova-plugin-geolocation/pull/55.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #55
----
commit cbdcedf056bbe8ee932b8542582520f6a3b4eca5
Author: Jesse MacFadyen <[email protected]>
Date: 2015-10-27T23:45:07Z
CB-4596 Date objects are supposed to be DOMTimeStamp (s)
commit 163051aa38547eb09eef65b9f5267db1bc8c375f
Author: Jesse MacFadyen <[email protected]>
Date: 2015-10-27T23:51:53Z
Fixed lint errors.
commit bf8a373418f3056da93c85f957d91197f51db18a
Author: Jesse MacFadyen <[email protected]>
Date: 2015-10-28T00:28:50Z
Expect lastPosition to have a timestamp that is already in msecs
(DOMTimeStamp)
----
> Documentation is not consistent for timestamp types
> ---------------------------------------------------
>
> Key: CB-4596
> URL: https://issues.apache.org/jira/browse/CB-4596
> Project: Apache Cordova
> Issue Type: Improvement
> Components: Docs, Plugin Device Motion, Plugin Device Orientation,
> Plugin Geolocation
> Affects Versions: 2.9.0
> Reporter: Peter
> Assignee: Jesse MacFadyen
> Priority: Minor
>
> Compare Codova documentation for these timestamps:
> * Accelerometer > *Acceleration.timestamp* - _timestamp: Creation timestamp
> in milliseconds. (DOMTimeStamp)_
> * Compass > *CompassHeading.timestamp* - _timestamp: The time at which this
> heading was determined. (milliseconds)_
> * Geolocation > *Position.timestamp* - _timestamp: Creation timestamp for
> coords. (Date)_
> It is confusing that documentation describes all these "timestamps" to have
> different types.
> On closer inspection, for some reason the Position.timestamp really is
> (inconsistent with the others) returned as a Date object.
> But at least Acceleration/Compass ones seem to have same units so perhaps the
> documentation for those ones ought to consistently say they are DOMTimeStamp.
> Ref http://dev.w3.org/2006/webapi/WebIDL/#common-DOMTimeStamp
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
