[
https://issues.apache.org/jira/browse/CB-9590?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14987650#comment-14987650
]
ASF GitHub Bot commented on CB-9590:
------------------------------------
Github user david-barth-canonical commented on the pull request:
https://github.com/apache/cordova-lib/pull/294#issuecomment-153422772
I have update the pull request to add support for taking the class name
from the plugin.xml file. For plugins using one of the 2 existing naming
conventions, we can fallback to "guess work", otherwise new plugins using
arbitrary names can just specify the 'package-ubuntu' parameter (like iOS or
Android) to specify the class name directly.
I decided to go ahead and keep on adding code to the cordova-lib for now,
but will start adding support for that preparation step in cordova-ubuntu
direclty. In 2 steps, I imagine we can migrate core plugins to using the new
parameter and deprecate the specific code from the ubuntu/install stage in
cordova-lib eventually.
> install header-files breaks with new naming convention on ubuntu
> ----------------------------------------------------------------
>
> Key: CB-9590
> URL: https://issues.apache.org/jira/browse/CB-9590
> Project: Apache Cordova
> Issue Type: Bug
> Components: CordovaLib
> Reporter: David Barth
>
> Trying to install a plugin using the new naming convention breaks on the
> current ubuntu version.
> cordova plugin add cordova-plugin-console
> Fetching plugin "cordova-plugin-console" via npm
> npm http GET https://registry.npmjs.org/cordova-plugin-console
> npm http 304 https://registry.npmjs.org/cordova-plugin-console
> Installing "cordova-plugin-console" for ubuntu
> Error during processing of action! Attempting to revert...
> Failed to install 'cordova-plugin-console':TypeError: Uh oh!
> Cannot read property '0' of null
> at Object.module.exports.header-file.install
> (/usr/share/cordova-cli/node_modules/cordova-lib/src/plugman/platforms/ubuntu.js:74:57)
> at installWrapper
> (/usr/share/cordova-cli/node_modules/cordova-lib/src/platforms/platforms.js:76:32)
> at Object.ActionStack.process
> (/usr/share/cordova-cli/node_modules/cordova-lib/src/plugman/util/action-stack.js:68:25)
> at handleInstall
> (/usr/share/cordova-cli/node_modules/cordova-lib/src/plugman/install.js:543:20)
> at
> /usr/share/cordova-cli/node_modules/cordova-lib/src/plugman/install.js:335:28
> at _fulfilled (/usr/share/cordova-cli/node_modules/q/q.js:787:54)
> at self.promiseDispatch.done
> (/usr/share/cordova-cli/node_modules/q/q.js:816:30)
> at Promise.promise.promiseDispatch
> (/usr/share/cordova-cli/node_modules/q/q.js:749:13)
> at /usr/share/cordova-cli/node_modules/q/q.js:509:49
> at flush (/usr/share/cordova-cli/node_modules/q/q.js:108:17)
> TypeError: Uh oh!
> Cannot read property '0' of null
> at Object.module.exports.header-file.install
> (/usr/share/cordova-cli/node_modules/cordova-lib/src/plugman/platforms/ubuntu.js:74:57)
> at installWrapper
> (/usr/share/cordova-cli/node_modules/cordova-lib/src/platforms/platforms.js:76:32)
> at Object.ActionStack.process
> (/usr/share/cordova-cli/node_modules/cordova-lib/src/plugman/util/action-stack.js:68:25)
> at handleInstall
> (/usr/share/cordova-cli/node_modules/cordova-lib/src/plugman/install.js:543:20)
> at
> /usr/share/cordova-cli/node_modules/cordova-lib/src/plugman/install.js:335:28
> at _fulfilled (/usr/share/cordova-cli/node_modules/q/q.js:787:54)
> at self.promiseDispatch.done
> (/usr/share/cordova-cli/node_modules/q/q.js:816:30)
> at Promise.promise.promiseDispatch
> (/usr/share/cordova-cli/node_modules/q/q.js:749:13)
> at /usr/share/cordova-cli/node_modules/q/q.js:509:49
> at flush (/usr/share/cordova-cli/node_modules/q/q.js:108:17)
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
