[
https://issues.apache.org/jira/browse/CB-9883?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15000059#comment-15000059
]
ASF GitHub Bot commented on CB-9883:
------------------------------------
Github user purplecabbage commented on the pull request:
https://github.com/apache/cordova-ios/pull/179#issuecomment-155692488
Is this sufficient in the wkwebview plugin?
```
if(window.webkit && window.webkit.messageHandler) {
module.exports = iOSExec;
}
else {
// this will end up clobbering cordova.exec with cordova.exec
// a special case for falling back to UIWebView
module.exports = cordova.exec;
}
```
It will prevent the clobber in this case.
> Remove unused iOS bridges
> -------------------------
>
> Key: CB-9883
> URL: https://issues.apache.org/jira/browse/CB-9883
> Project: Apache Cordova
> Issue Type: Bug
> Components: iOS
> Reporter: Shazron Abdullah
> Assignee: Jesse MacFadyen
> Labels: cordova-ios-4.0.x
>
> We have 7 bridges in iOS:
> https://github.com/apache/cordova-ios/blob/c0fe92d6c0b91efa2da0d5cec78e0baa95ce55c9/cordova-js-src/exec.js#L36-L43
> IFRAME_NAV is the default, and is actively used.
> WK_WEBVIEW_BINDING will be used by the wkwebview-engine plugin,
> although I really want the plugin itself to inject this, haven't
> explored that yet.
> Remove these bridges:
> https://github.com/apache/cordova-ios/blob/c0fe92d6c0b91efa2da0d5cec78e0baa95ce55c9/cordova-js-src/exec.js#L38-L42
> XHR_NO_PAYLOAD
> XHR_WITH_PAYLOAD
> XHR_OPTIONAL_PAYLOAD
> IFRAME_HASH_NO_PAYLOAD
> IFRAME_HASH_WITH_PAYLOAD
> ... and their associated native code.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
