[
https://issues.apache.org/jira/browse/CB-7006?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15000406#comment-15000406
]
ASF GitHub Bot commented on CB-7006:
------------------------------------
GitHub user daserge opened a pull request:
https://github.com/apache/cordova-plugin-file-transfer/pull/113
CB-7006 Empty file is created on file transfer if server response is 304
Adds a corresponding test.
Fixes the Windows proxy to not to delete the file in case of 304.
As a side effect the new code will not delete a cached file (previously
downloaded f.e.) in case of a download error.
The test is passing on Android and Windows (with this modification) and
fails on iOS as code 200 comes for the second request disregarding the
`If-Modified-Since` header, as soon as we get code 200 in the first request
(the file is being cached by the iOS proxy somewhere).
@shazron, could you please point to where to look at in the iOS
implementation for this caching?
[Jira issue](https://issues.apache.org/jira/browse/CB-7006)
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/MSOpenTech/cordova-plugin-file-transfer
CB-7006
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/cordova-plugin-file-transfer/pull/113.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #113
----
commit a85d54da8db9b52bc55160b933640b05383464e1
Author: daserge <[email protected]>
Date: 2015-11-11T11:06:23Z
CB-7006 Empty file is created on file transfer if server response is 304
Adds a corresponding test.
Fixes the Windows proxy to not to delete the file in case of 304.
As a side effect the new code will not delete a cached file in case of a
download error.
----
> [cordova-plugin-file-transfer] Empty file is created on file transfer if
> server response is 304.
> ------------------------------------------------------------------------------------------------
>
> Key: CB-7006
> URL: https://issues.apache.org/jira/browse/CB-7006
> Project: Apache Cordova
> Issue Type: Bug
> Components: Plugin File Transfer
> Environment: Android 4.3, cordova 3.4.1, plugin-file-transfer r0.4.4
> Reporter: Romain Garrigues
>
> Hi,
> I want to use file transfer plugin with "If-Modified-Since" HTTP header.
> When receiving 304 status code from server (file not changed), It seems that
> file transfer plugin overwrites the current file on device by... new empty
> one.
> As plugin does not verify HTTP response status code, and HTTP 304 response
> contains an empty body content, maybe that's a point to check to avoid
> overwriting already present data ?
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
