[
https://issues.apache.org/jira/browse/CB-9971?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15001076#comment-15001076
]
ASF GitHub Bot commented on CB-9971:
------------------------------------
Github user vladimir-kotikov commented on a diff in the pull request:
https://github.com/apache/cordova-android/pull/240#discussion_r44585568
--- Diff: bin/templates/cordova/lib/builders/GradleBuilder.js ---
@@ -211,3 +209,46 @@ module.exports = GradleBuilder;
function isAutoGenerated(file) {
return fs.existsSync(file) && fs.readFileSync(file,
'utf8').indexOf(MARKER) > 0;
}
+
+/**
+ * A special superspawn-like implementation, required to workaround the
issue
--- End diff --
Not even an additional option, but an ability to accept any valid `stdio`
option - `superspawn` now knows only `default`, `ignore` and `inherit`. I
agree, this will be the most correct solution, but will require patching this
in cordova-common and releasing it before next android release.
@jasongin, what do you think?
> Cordova outputs "Picked up _JAVA_OPTIONS" in stderr
> ---------------------------------------------------
>
> Key: CB-9971
> URL: https://issues.apache.org/jira/browse/CB-9971
> Project: Apache Cordova
> Issue Type: Bug
> Components: Android
> Affects Versions: 5.0.0
> Environment: Windows, Tools for Apache Cordova in Visual Studio
> Cordova 5.4.0
> Reporter: Michael Braude
> Assignee: Vladimir Kotikov
> Priority: Critical
> Labels: easyfix, windows,
> Original Estimate: 2h
> Remaining Estimate: 2h
>
> Starting with version 5.4.0, Cordova now outputs "Picked up _JAVA_OPTIONS:
> -Xmx512M" to stderr. This breaks clients such as Visual Studio because we
> interpret messages in stderr to be errors, and this is not an error. So the
> result is that we show deploy failures to the dev when there are no errors.
> See this for customer impact:
> http://stackoverflow.com/questions/33603167/vs2015-build-with-cordova-cli5-4-0-shows-deployment-errors
> We can work around this in Visual Studio by using special casing, but Cordova
> needs to output this in stdout like it did in previous versions
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
