[
https://issues.apache.org/jira/browse/CB-8156?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15022624#comment-15022624
]
ASF GitHub Bot commented on CB-8156:
------------------------------------
Github user purplecabbage commented on a diff in the pull request:
https://github.com/apache/cordova-plugin-contacts/pull/84#discussion_r45637931
--- Diff: src/windows/ContactProxy.js ---
@@ -242,7 +242,9 @@ module.exports = {
pickRequest.done(function (contact) {
// if contact was not picked
if (!contact) {
- fail && fail(new Error("User did not pick a contact."));
--- End diff --
This looks good. The implied check for `fail != null` here was unnecessary
as ALL calls to exec proxies have valid success/error function passed in.
> [Contacts] Cancelling pickContact should call the error callback, but
> callback "nothing" for now
> ------------------------------------------------------------------------------------------------
>
> Key: CB-8156
> URL: https://issues.apache.org/jira/browse/CB-8156
> Project: Apache Cordova
> Issue Type: Bug
> Components: Plugin Contacts
> Environment: I using ipad mini 8.1.2 with phonegap 3.6.3 or 3.7.1 and
> latest contact plugin
> Reporter: Colin Bau
> Assignee: Vladimir Kotikov
> Labels: android, ios, regression, reproduced, triaged
>
> according to this
> https://issues.apache.org/jira/browse/CB-7772
> it have been solved
> Cancelling pickContact should call the error callback, but callback "nothing"
> (no any response) for now
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
