[
https://issues.apache.org/jira/browse/CB-8641?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15027744#comment-15027744
]
ASF GitHub Bot commented on CB-8641:
------------------------------------
Github user dblotsky commented on a diff in the pull request:
https://github.com/apache/cordova-plugin-file-transfer/pull/118#discussion_r45928408
--- Diff: src/windows/FileTransferProxy.js ---
@@ -116,9 +118,13 @@ exec(win, fail, 'FileTransfer', 'upload',
// check if download isn't already cancelled
var uploadOp = fileTransferOps[uploadId];
- if (uploadOp && uploadOp.state ===
FileTransferOperation.CANCELLED) {
+ if (uploadOp && uploadOp.state ===
FileTransferOperation.CANCELLED || abortedOpIds.indexOf(uploadId) !== -1) {
--- End diff --
This condition is hard to read. Please encapsulate this logic in a
descriptive function.
> (Windows Phone 8.1) Some file-transfer plugin tests occasionally fail in
> mobilespec
> -----------------------------------------------------------------------------------
>
> Key: CB-8641
> URL: https://issues.apache.org/jira/browse/CB-8641
> Project: Apache Cordova
> Issue Type: Bug
> Components: Plugin File Transfer
> Reporter: Alexander Sorokin
> Priority: Minor
> Fix For: Master
>
>
> Some file-transfer plugin tests occasionally fail in mobilespec:
> File-transfer.spec.10 download should be stopped by abort() right away
> File-transfer.spec.21 upload should be stopped by abort() right away
> The issue seems to be caused by insufficient timeout and could be fixed by
> increasing it.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
