[
https://issues.apache.org/jira/browse/CB-8917?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15032783#comment-15032783
]
ASF GitHub Bot commented on CB-8917:
------------------------------------
Github user riknoll commented on the pull request:
https://github.com/apache/cordova-android/pull/239#issuecomment-160807204
Apologies for not getting to this last week like I said I would (I didn't
really have much of an Internet connection). I did some more testing on this PR
today and found a few bugs/edge cases that I've now fixed. This PR has been
rebased to master and I pushed a new commit that handles the following:
* PluginResults with multipart messages are now handled properly in the
`resume` payload
* The `resume` event is now fired when the Activity is destroyed even if
there isn't a pending result
* A potential concurrency issue in CoreAndroid has been handled
Please review this new commit. Since I pushed some changes I will wait to
merge this in until end of day tomorrow. Let met know if there are any
objections. For the record, I tested as follows:
* Ran mobilespec auto tests on a 6.0.0 device and a 5.1.1 emulator (minus
the file transfer tests) and confirmed output matched master (one orientation
failure on 5.1.1, but I believe it is the emulator's fault)
* Ran the platform unit tests on a 6.0.0 device and a 5.1.1 emulator and
confirmed output matched master (one failure)
* Did some manual testing with a 6.0.0 device and a 5.1.1 emulator
> Add api/way to get plugins results even when Cordova activity restarts
> ------------------------------------------------------------------------
>
> Key: CB-8917
> URL: https://issues.apache.org/jira/browse/CB-8917
> Project: Apache Cordova
> Issue Type: Improvement
> Components: Android
> Reporter: Bnaya
>
> In android when you have a plugin that opens new activity the CordovaActivity
> will be killed and you won't get the result from the plugin.
> The new activity will get the results but because the plugin objects are dead
> and the webview reloaded you can get the data to the js callback.
> The most noticeable example is the camera plugin. (And maybe its the same
> with even more platforms)
> possible solution for this is to add metadata to the device ready event with
> incoming data from plugins.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
