[
https://issues.apache.org/jira/browse/CB-9840?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15046541#comment-15046541
]
ASF GitHub Bot commented on CB-9840:
------------------------------------
Github user daserge commented on a diff in the pull request:
https://github.com/apache/cordova-labs/pull/10#discussion_r46923583
--- Diff: server.js ---
@@ -6,6 +6,11 @@ var formidable = require('formidable'),
var DIRECT_UPLOAD_LIMIT = 32; // bytes
+// convert from UTF-8 to ISO-8859-1
+var LATIN1_SYMBOLS = '¥§©ÆÖÑøøø¼';
--- End diff --
The tests 36 and 37 verify the proper handling of a server Latin1 response.
We could avoid this string constant by changing the tests to pass the
symbols in the headers or params but I'm not sure if it will be retrieved
correctly (in terms of encoding) by the server and whether it will be needed to
be converted to Latin1 after that.
As for the fact that it matches the constant from file-transfer tests - the
situation for maintaining this is the same as for cordova_user/cordova_password
- or am I missing something?
> Fallback file-transfer uploadResponse encoding to latin1 in case not encoded
> with UTF-8 on iOS
> ----------------------------------------------------------------------------------------------
>
> Key: CB-9840
> URL: https://issues.apache.org/jira/browse/CB-9840
> Project: Apache Cordova
> Issue Type: Bug
> Components: Plugin File Transfer
> Reporter: Sergey Shakhnazarov
> Assignee: Sergey Shakhnazarov
> Priority: Minor
> Labels: ios
>
> Otherwise the response is empty in the current version.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
