[ 
https://issues.apache.org/jira/browse/CB-10140?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15048322#comment-15048322
 ] 

ASF GitHub Bot commented on CB-10140:
-------------------------------------

GitHub user CookieCookson opened a pull request:

    https://github.com/apache/cordova-android/pull/244

    CB-10140 Use application id instead of package name when running

    

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/CookieCookson/cordova-android applicationid

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/cordova-android/pull/244.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #244
    
----
commit 6b0cdfc6b8cba99669ff689316533f6f48ecb110
Author: Christian Cook <[email protected]>
Date:   2015-12-03T14:00:36Z

    create aapt function to get application id from apk

commit ea1e09fb85d65248030d406340b3ff49225fdebf
Author: Christian Cook <[email protected]>
Date:   2015-12-03T14:00:54Z

    use application id in device installs

commit 1ed0b8547fb4551416c471599c41e085d4a288cd
Author: Christian Cook <[email protected]>
Date:   2015-12-04T11:04:59Z

    fixes applicationId not being set for uninstall process

commit dd57d1542ad2a369955a39bffbcd4cdacef0df8c
Author: Christian Cook <[email protected]>
Date:   2015-12-04T15:53:57Z

    uses application id on emulator install

----


> Use application id instead of package name when running
> -------------------------------------------------------
>
>                 Key: CB-10140
>                 URL: https://issues.apache.org/jira/browse/CB-10140
>             Project: Apache Cordova
>          Issue Type: Improvement
>          Components: Android, CLI
>            Reporter: Christian Cook
>            Priority: Minor
>
> I've been working on a new plugin for Cordova which will allow you to easily 
> deploy different build types in a system lifecycle e.g. alpha, beta and 
> store. This will allow multiple instances of the same app on your device in 
> different states. Currently I've hit a bit of an interesting bug/issue when 
> using this in conjunction with the run command. When the plugin operates it 
> dynamically changes the application id depending on the state so com.test.app 
> becomes com.test.app.alpha and so son. Because of this, when running the app 
> from the CLI it then starts using the incorrect ID (it uses the packageName 
> from the Android Manifest and tries to run nothing or the wrong instance). 
> Below I have put together a solution which solves this issue. Would somebody 
> be able to assess this and give me your thoughts on the improvement?
> https://github.com/CookieCookson/cordova-android/compare/master...CookieCookson:applicationid



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to