[ 
https://issues.apache.org/jira/browse/CB-10156?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15057745#comment-15057745
 ] 

Shazron Abdullah edited comment on CB-10156 at 12/15/15 10:05 AM:
------------------------------------------------------------------

Ultimately the code that does this is in 
https://github.com/alunny/node-xcode/blob/56560ab1d767ea81d33cde50f98cc52646ab5fa7/lib/pbxProject.js#L1024-L1042

which then calls this:
https://github.com/alunny/node-xcode/blob/56560ab1d767ea81d33cde50f98cc52646ab5fa7/lib/pbxProject.js#L1480-L1498

Since it's a custom framework, it will go to this condition:
https://github.com/alunny/node-xcode/blob/56560ab1d767ea81d33cde50f98cc52646ab5fa7/lib/pbxProject.js#L1493-L1494

so file.dirname is returning a path with backslashes, which I surmise could 
only happen on a Windows system (since path.sep would be a backslash on it). 
Was the plugin added from a Windows system?

In any case... it's still a bug -- the path saved should always use the Unix 
path.sep (forward slash).



was (Author: shazron):
Ultimately the code that does this is in 
https://github.com/alunny/node-xcode/blob/56560ab1d767ea81d33cde50f98cc52646ab5fa7/lib/pbxProject.js#L1024-L1042

which then cals this:
https://github.com/alunny/node-xcode/blob/56560ab1d767ea81d33cde50f98cc52646ab5fa7/lib/pbxProject.js#L1480-L1498

Since it's a custom framework, it will go to this condition:
https://github.com/alunny/node-xcode/blob/56560ab1d767ea81d33cde50f98cc52646ab5fa7/lib/pbxProject.js#L1493-L1494

so file.dirname is returning a path with backslashes, which I surmise could 
only happen on a Windows system (since path.sep would be a backslash on it). 
Was the plugin added from a Windows system?

In any case... it's still a bug -- the path saved should always use the Unix 
path.sep (forward slash).


> iOS platform FRAMEWORK_SEARCH_PATHS with add custom framework in plugin
> -----------------------------------------------------------------------
>
>                 Key: CB-10156
>                 URL: https://issues.apache.org/jira/browse/CB-10156
>             Project: Apache Cordova
>          Issue Type: Bug
>          Components: CLI
>    Affects Versions: 5.4.1
>            Reporter: Clark
>            Assignee: Shazron Abdullah
>              Labels: cordova-6.0.0, cordova-ios-4.0.1
>
> iOS platform FRAMEWORK_SEARCH_PATHS with add custom framework in plugin
> ========================
> Error :
> FRAMEWORK_SEARCH_PATHS = (
>     "$(inherited)",
>     "\"BlankCordovaApp1\Plugins\myPlugin\"",
> );
> ====================
> Right:
> FRAMEWORK_SEARCH_PATHS = (
>     "$(inherited)",
>     "\"BlankCordovaApp1/Plugins/myPlugin\"",
> );



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to