[ 
https://issues.apache.org/jira/browse/CB-9949?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15061276#comment-15061276
 ] 

Joe Bowser edited comment on CB-9949 at 12/21/15 3:59 AM:
----------------------------------------------------------

[~marfire] Given that the Back Button is a frowned upon practice, I'm more than 
happy with the extra line.  Honestly, I don't even think that the back button 
should really be supported at all, but this code is minimal.  

Given that the change to make it not break your app is a JS fix, you should 
submit another pull request, and I may look at it assuming I can merge it in 
cleanly.


was (Author: bowserj):
[~marfire] Given that the Back Button is a frowned upon practice, I'm more than 
happy with the extra line.  Honestly, I don't even think that the back button 
should really be supported at all, but this code is minimal.  

Given that the change to make it not break your API is a JS fix, you should 
submit another pull request, and I may look at it assuming I can merge it in 
cleanly.

> Menu button event not fired in Android
> --------------------------------------
>
>                 Key: CB-9949
>                 URL: https://issues.apache.org/jira/browse/CB-9949
>             Project: Apache Cordova
>          Issue Type: Bug
>          Components: Android
>    Affects Versions: 5.3.2
>            Reporter: Keith Wong
>            Assignee: Joe Bowser
>         Attachments: cordova-android.patch
>
>
> The menu button event handler is not called when the menu button is pressed



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to