[ 
https://issues.apache.org/jira/browse/CB-10047?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15068892#comment-15068892
 ] 

ASF GitHub Bot commented on CB-10047:
-------------------------------------

GitHub user jcesarmobile opened a pull request:

    https://github.com/apache/cordova-plugin-statusbar/pull/41

    CB-10047 fix iOS 8 deprecated warnings and CB-10102 wrong removeObserver

    CB-10047 
    Removed all references to self.viewController.interfaceOrientation,
    they weren’t really used on invertFrameIfNeeded and are deprecated on
    iOS 8
    Removed orientation param on invertFrameIfNeeded as it wasn’t being
    used.
    
     CB-10102 fixed wrong removeObserver

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/jcesarmobile/cordova-plugin-statusbar 
CB-10047-CB-10102-fix-statusbar

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/cordova-plugin-statusbar/pull/41.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #41
    
----
commit 1d9712d9995e0e4b14466fda0059e6b15653c78e
Author: Julio César <[email protected]>
Date:   2015-12-22T23:10:34Z

    CB-10047 fix iOS 8 deprecated warnings and CB-10102, wrong removeObserver
    
    Removed all references to self.viewController.interfaceOrientation,
    they weren’t really used on invertFrameIfNeeded and are deprecated on
    iOS 8
    Removed orientation param on invertFrameIfNeeded as it wasn’t being
    used.

----


> [StatusBar] Fix iOS8 Deprecation Warnings
> -----------------------------------------
>
>                 Key: CB-10047
>                 URL: https://issues.apache.org/jira/browse/CB-10047
>             Project: Apache Cordova
>          Issue Type: Bug
>          Components: Plugin Statusbar
>            Reporter: jordan cardwell
>            Assignee: jcesarmobile
>            Priority: Minor
>              Labels: deprecated, deprecation
>
> Issue has been around for a while
> [https://github.com/apache/cordova-plugin-statusbar/pull/26]
> After use Cordova build ios
> there are some warning about UIDeviceOrientation and UIInterfaceOrientation:
> Implicit conversion from enumeration type "UIDeviceOrientation"(aka "enum 
> UIDeviceOrientation") to different enumeration type "UIInterfaceOrientation" 
> (aka "enum UIInterfaceOrientation")
> Based on current ios api, UIViewControl.interfaceOrientation has been 
> deprecated.
> Fixed those warning using function: [[UIDevice currentDevice] orientation] 
> instead of self.viewController.interfaceOrientation



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to