[
https://issues.apache.org/jira/browse/CB-9240?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15074185#comment-15074185
]
ASF GitHub Bot commented on CB-9240:
------------------------------------
GitHub user daserge opened a pull request:
https://github.com/apache/cordova-plugin-splashscreen/pull/72
CB-9240 Cordova splash screen plugin iPad landscape mode issue
[Jira issue](https://issues.apache.org/jira/browse/CB-9240)
Aligns `shouldAutoRotate` default value with [parent CDVViewController
behavior](https://github.com/apache/cordova-ios/blob/d3c5519719d172bfcf6d994c740615b6fdfa91e6/CordovaLib/Classes/Public/CDVViewController.m#L352-L355).
This fix also does not break iPhone rotation behavior - it's being turned
on after splashscreen hide and swizzling dismissal.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/MSOpenTech/cordova-plugin-splashscreen CB-9240
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/cordova-plugin-splashscreen/pull/72.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #72
----
commit 3b2e9e59124e345c61235ca132e8f519d7df8ead
Author: daserge <[email protected]>
Date: 2015-12-29T19:08:02Z
CB-9240 Cordova splash screen plugin iPad landscape mode issue
Aligns shouldRotate default value with parent CDVViewController behavior
----
> Cordova splash screen plugin iPad landscape mode issue
> ------------------------------------------------------
>
> Key: CB-9240
> URL: https://issues.apache.org/jira/browse/CB-9240
> Project: Apache Cordova
> Issue Type: Bug
> Components: Plugin SplashScreen
> Environment: iPad iOS 8
> Reporter: Hetal
> Labels: ios, landscape, plugin, reproduced, splashscreen, triaged
>
> I am using the Cordova splash screen plugin
> (https://github.com/apache/cordova-plugin-splashscreen) in my hybrid mobile
> app targeted for iOS. I have all the splash screen images added to my
> project. The reason for using this plugin is to elongate the time for which
> the splash screen is shown and I manually hide it later in the app. So my
> config.xml has the following declarations:
> <preference name="AutoHideSplashScreen" value="false" />
> <preference name="ShowSplashScreenSpinner" value="false"/>
> This plugin works fine in the portrait mode on iPhone and iPad. But on the
> iPad in landscape mode, the plugin shows the splash image in portrait mode
> and consequently my first app view also shows in the portrait mode even
> though the device is in landscape mode.
> The screenshots are available here:
> http://stackoverflow.com/questions/31035650/cordova-splash-screen-plugin-ipad-landscape-mode-issue
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
