[
https://issues.apache.org/jira/browse/CB-10274?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15074946#comment-15074946
]
ASF GitHub Bot commented on CB-10274:
-------------------------------------
Github user vladimir-kotikov commented on a diff in the pull request:
https://github.com/apache/cordova-lib/pull/359#discussion_r48599256
--- Diff: cordova-lib/src/plugman/install.js ---
@@ -596,11 +596,14 @@ function handleInstall(actions, pluginInfo, platform,
project_dir, plugins_dir,
events.emit('verbose', 'Install start for "' + pluginInfo.id + '" on '
+ platform + '.');
options.variables = filtered_variables;
- // Set up platform to install asset files/js modules to
<platform>/platform_www dir
- // instead of <platform>/www. This is required since on each prepare
platform's www dir is changed
- // and files from 'platform_www' merged into 'www'. Thus we need to
persist these
- // files platform_www directory, so they'll be applied to www on each
prepare.
- options.usePlatformWww = true;
+ if (!('www_dir' in options) || options.www_dir === undefined) {
--- End diff --
There is some inconsistency in how this option should be specified: the
[plugman's
README](https://github.com/apache/cordova-plugman/blob/master/README.md#plugin-management)
states that there is `--www` option for plugman cli, [comments in cordova-lib
code](https://github.com/apache/cordova-lib/blob/master/cordova-lib/src/plugman/install.js#L68)
metntion `www_dir` option, but there is no code, reponsible for conversion
`--www` -> `www_dir`
> plugman ignores --www parameter
> -------------------------------
>
> Key: CB-10274
> URL: https://issues.apache.org/jira/browse/CB-10274
> Project: Apache Cordova
> Issue Type: Bug
> Reporter: Brad Reynolds
>
> I'm attempting to manage plugins via plugman rather than the cordova CLI. I
> have a couple small changes in the source of each platform project that I
> need to maintain. According to this
> [document|http://cordova.apache.org/docs/en/latest/plugin_ref/plugman.html]
> this is supported via plugman. Unfortunately plugman is installing plugins
> to platform_www rather than what I provide on the command line.
> {code}
> ± % cordova -v
> 5.4.1
> {code}
> Steps to reproduce:
> 1. Create a new cordova project.
> 2. Add an iOS platform.
> 3. Run the following:
> {code}
> plugman install --www platforms/ios/www --platform ios --project
> platforms/ios --plugin cordova-plugin-uniquedeviceid
> {code}
> The result will be the following changes:
> {code}
> ± % git status
>
>
>
> !10076
> On branch master
> Changes not staged for commit:
> (use "git add <file>..." to update what will be committed)
> (use "git checkout -- <file>..." to discard changes in working directory)
> modified: platforms/ios/HelloCordova.xcodeproj/project.pbxproj
> modified: platforms/ios/HelloCordova/config.xml
> modified: platforms/ios/ios.json
> modified: platforms/ios/platform_www/cordova_plugins.js
> Untracked files:
> (use "git add <file>..." to include in what will be committed)
> platforms/ios/HelloCordova/Plugins/cordova-plugin-uniquedeviceid/
> platforms/ios/cordova/plugins/
> platforms/ios/frameworks.json
> platforms/ios/platform_www/plugins/
> {code}
> As you can see above plugman is modifying platform_www/plugins rather than
> the plugin directory I provided. I also tried to use 'www' as the path but
> receive the same result. From what I can tell the only way to apply the
> changes from platform_www to www is to run 'cordova prepare' but I can't do
> that as it will wipe out changes I've made to the platform projects.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
